Skip to content

Commit 74a6b69

Browse files
authored
chore: fix tests on Windows and enable it in actions (#518)
Use a gitattributes file to force text files to be checked out with LF line endings. This resolves issues on Windows with tests that compare values with the contents of files on disk.
1 parent 3ca0fb4 commit 74a6b69

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.gitattributes

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# Force checking out with LF on Windows to avoid issues in tests that read files.
2+
* text=auto eol=lf

.github/workflows/nodejs.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ jobs:
2727
fail-fast: false
2828
matrix:
2929
node-version: [10.x, 12.x, 14.x, 15.x]
30-
# TODO(targos): fix and add windows-latest
31-
os: [ubuntu-latest, macOS-latest]
30+
os: [ubuntu-latest, macOS-latest, windows-latest]
3231
runs-on: ${{ matrix.os }}
3332
steps:
3433
- uses: actions/checkout@v2

0 commit comments

Comments
 (0)