Skip to content

Commit 591a4d1

Browse files
committed
fixup! fixup! src: make BuiltinLoader threadsafe and non-global
1 parent a26322c commit 591a4d1

File tree

3 files changed

+2
-5
lines changed

3 files changed

+2
-5
lines changed

Diff for: src/node.cc

-2
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,6 @@
126126

127127
namespace node {
128128

129-
using builtins::BuiltinLoader;
130-
131129
using v8::EscapableHandleScope;
132130
using v8::Isolate;
133131
using v8::Local;

Diff for: src/node_realm.cc

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
namespace node {
1010

11-
using builtins::BuiltinLoader;
1211
using v8::Context;
1312
using v8::EscapableHandleScope;
1413
using v8::Function;

Diff for: src/node_threadsafe_cow.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ class ThreadsafeCopyOnWrite final {
8080

8181
private:
8282
struct Impl {
83-
Impl(const T& data) : data(data) {}
84-
Impl(T&& data) : data(std::move(data)) {}
83+
explicit Impl(const T& data) : data(data) {}
84+
explicit Impl(T&& data) : data(std::move(data)) {}
8585

8686
Impl(const Impl& other);
8787
Impl& operator=(const Impl& other) = delete;

0 commit comments

Comments
 (0)