Skip to content

Commit 5aeaff6

Browse files
rickyesmcollina
authored andcommitted
stream: refactor lazyLoadPromises
PR-URL: #34354 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent 08e8997 commit 5aeaff6

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

Diff for: lib/stream.js

+8-6
Original file line numberDiff line numberDiff line change
@@ -49,28 +49,30 @@ Stream.PassThrough = require('_stream_passthrough');
4949
Stream.pipeline = pipeline;
5050
Stream.finished = eos;
5151

52+
function lazyLoadPromises() {
53+
if (promises === null) promises = require('stream/promises');
54+
return promises;
55+
}
56+
5257
ObjectDefineProperty(Stream, 'promises', {
5358
configurable: true,
5459
enumerable: true,
5560
get() {
56-
if (promises === null) promises = require('stream/promises');
57-
return promises;
61+
return lazyLoadPromises();
5862
}
5963
});
6064

6165
ObjectDefineProperty(pipeline, customPromisify, {
6266
enumerable: true,
6367
get() {
64-
if (promises === null) promises = require('stream/promises');
65-
return promises.pipeline;
68+
return lazyLoadPromises().pipeline;
6669
}
6770
});
6871

6972
ObjectDefineProperty(eos, customPromisify, {
7073
enumerable: true,
7174
get() {
72-
if (promises === null) promises = require('stream/promises');
73-
return promises.finished;
75+
return lazyLoadPromises().finished;
7476
}
7577
});
7678

0 commit comments

Comments
 (0)