Skip to content

Commit 7e87520

Browse files
etiennep-chromiumtargos
authored andcommitted
src: update GetForegroundTaskRunner override
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5758110 PR-URL: #55014 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
1 parent 44b0e42 commit 7e87520

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

src/node_platform.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -556,8 +556,8 @@ bool NodePlatform::IdleTasksEnabled(Isolate* isolate) {
556556
return ForIsolate(isolate)->IdleTasksEnabled();
557557
}
558558

559-
std::shared_ptr<v8::TaskRunner>
560-
NodePlatform::GetForegroundTaskRunner(Isolate* isolate) {
559+
std::shared_ptr<v8::TaskRunner> NodePlatform::GetForegroundTaskRunner(
560+
Isolate* isolate, v8::TaskPriority priority) {
561561
return ForIsolate(isolate)->GetForegroundTaskRunner();
562562
}
563563

src/node_platform.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ class NodePlatform : public MultiIsolatePlatform {
182182
void* data) override;
183183

184184
std::shared_ptr<v8::TaskRunner> GetForegroundTaskRunner(
185-
v8::Isolate* isolate) override;
185+
v8::Isolate* isolate, v8::TaskPriority priority) override;
186186

187187
Platform::StackTracePrinter GetStackTracePrinter() override;
188188
v8::PageAllocator* GetPageAllocator() override;

test/cctest/test_platform.cc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ class RepostingTask : public v8::Task {
2424
if (repost_count_ > 0) {
2525
--repost_count_;
2626
std::shared_ptr<v8::TaskRunner> task_runner =
27-
platform_->GetForegroundTaskRunner(isolate_);
27+
platform_->GetForegroundTaskRunner(isolate_,
28+
v8::TaskPriority::kUserBlocking);
2829
task_runner->PostTask(std::make_unique<RepostingTask>(
2930
repost_count_, run_count_, isolate_, platform_));
3031
}
@@ -46,7 +47,8 @@ TEST_F(PlatformTest, SkipNewTasksInFlushForegroundTasks) {
4647
Env env {handle_scope, argv};
4748
int run_count = 0;
4849
std::shared_ptr<v8::TaskRunner> task_runner =
49-
platform->GetForegroundTaskRunner(isolate_);
50+
platform->GetForegroundTaskRunner(isolate_,
51+
v8::TaskPriority::kUserBlocking);
5052
task_runner->PostTask(
5153
std::make_unique<RepostingTask>(2, &run_count, isolate_, platform.get()));
5254
EXPECT_TRUE(platform->FlushForegroundTasks(isolate_));

0 commit comments

Comments
 (0)