stream: pipeline accept Buffer as a valid first argument

change isStream to also check existence of on, so it
wont mistake buffers as Streams.

fixes: #37731

PR-URL: #37739
Fixes: #37731
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Author: Linkgoron

Diff for: lib/internal/streams/utils.js

@@ -6,11 +6,13 @@ const {
 } = primordials;
 
 function isReadable(obj) {
-  return !!(obj && typeof obj.pipe === 'function');
+  return !!(obj && typeof obj.pipe === 'function' &&
+            typeof obj.on === 'function');
 }
 
 function isWritable(obj) {
-  return !!(obj && typeof obj.write === 'function');
+  return !!(obj && typeof obj.write === 'function' &&
+            typeof obj.on === 'function');
 }
 
 function isStream(obj) {

Diff for: test/parallel/test-stream-pipeline.js

@@ -1371,3 +1371,19 @@ const net = require('net');
     assert.strictEqual(res, '123');
   }));
 }
+
+{
+  const content = 'abc';
+  pipeline(Buffer.from(content), PassThrough({ objectMode: true }),
+           common.mustSucceed(() => {}));
+
+  let res = '';
+  pipeline(Buffer.from(content), async function*(previous) {
+    for await (const val of previous) {
+      res += String.fromCharCode(val);
+      yield val;
+    }
+  }, common.mustSucceed(() => {
+    assert.strictEqual(res, content);
+  }));
+}