Skip to content

Commit c17fccb

Browse files
chore: simplified storybook/next config (#7280)
Co-authored-by: Augustin Mauroy <[email protected]>
1 parent d50d114 commit c17fccb

File tree

3 files changed

+14
-20
lines changed

3 files changed

+14
-20
lines changed

apps/site/.storybook/main.ts

-10
Original file line numberDiff line numberDiff line change
@@ -45,24 +45,14 @@ const config: StorybookConfig = {
4545
resolve: {
4646
...config.resolve,
4747
alias: {
48-
'@nodevu/core': false,
4948
'next-intl/navigation': join(mocksFolder, './next-intl.mjs'),
5049
'@/client-context': join(mocksFolder, './client-context.mjs'),
5150
'@': join(__dirname, '../'),
5251
},
5352
},
54-
// We need to configure `node:` APIs as Externals to WebPack
55-
// since essentially they're not supported on the browser
56-
externals: {
57-
'node:fs': 'commonjs fs',
58-
'node:url': 'commonjs url',
59-
'node:path': 'commonjs path',
60-
'node:readline': 'commonjs readline',
61-
},
6253
// Removes Pesky Critical Dependency Warnings due to `next/font`
6354
ignoreWarnings: [
6455
e =>
65-
e.message.includes('Critical dep') ||
6656
e.message.includes('was not found in') ||
6757
e.message.includes('generated code contains'),
6858
],

apps/site/next.config.mjs

+2-6
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,6 @@ import { redirects, rewrites } from './next.rewrites.mjs';
77

88
/** @type {import('next').NextConfig} */
99
const nextConfig = {
10-
// Just to ensure that React is always on strict mode
11-
reactStrictMode: true,
12-
// We intentionally disable Next.js's built-in i18n support
13-
// as we dom have our own i18n and internationalisation engine
14-
i18n: null,
1510
// We don't use trailing slashes on URLs from the Node.js Website
1611
trailingSlash: false,
1712
// We don't want to redirect with trailing slashes
@@ -23,7 +18,8 @@ const nextConfig = {
2318
images: {
2419
// We disable image optimisation during static export builds
2520
unoptimized: ENABLE_STATIC_EXPORT,
26-
// We add it to the remote pattern for the static images we use from GitHub
21+
// We add it to the remote pattern for the static images we use from multiple sources
22+
// to be marked as safe sources (these come from Markdown files)
2723
remotePatterns: [
2824
{
2925
protocol: 'https',

apps/site/turbo.json

+12-4
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@
1616
"NEXT_PUBLIC_BASE_PATH",
1717
"NEXT_PUBLIC_ORAMA_API_KEY",
1818
"NEXT_PUBLIC_ORAMA_ENDPOINT",
19-
"NEXT_PUBLIC_DATA_URL"
19+
"NEXT_PUBLIC_DATA_URL",
20+
"TURBO_CACHE",
21+
"TURBO_TELEMETRY_DISABLED"
2022
]
2123
},
2224
"build": {
@@ -39,7 +41,9 @@
3941
"NEXT_PUBLIC_BASE_PATH",
4042
"NEXT_PUBLIC_ORAMA_API_KEY",
4143
"NEXT_PUBLIC_ORAMA_ENDPOINT",
42-
"NEXT_PUBLIC_DATA_URL"
44+
"NEXT_PUBLIC_DATA_URL",
45+
"TURBO_CACHE",
46+
"TURBO_TELEMETRY_DISABLED"
4347
]
4448
},
4549
"start": {
@@ -55,7 +59,9 @@
5559
"NEXT_PUBLIC_BASE_PATH",
5660
"NEXT_PUBLIC_ORAMA_API_KEY",
5761
"NEXT_PUBLIC_ORAMA_ENDPOINT",
58-
"NEXT_PUBLIC_DATA_URL"
62+
"NEXT_PUBLIC_DATA_URL",
63+
"TURBO_CACHE",
64+
"TURBO_TELEMETRY_DISABLED"
5965
]
6066
},
6167
"deploy": {
@@ -77,7 +83,9 @@
7783
"NEXT_PUBLIC_BASE_PATH",
7884
"NEXT_PUBLIC_ORAMA_API_KEY",
7985
"NEXT_PUBLIC_ORAMA_ENDPOINT",
80-
"NEXT_PUBLIC_DATA_URL"
86+
"NEXT_PUBLIC_DATA_URL",
87+
"TURBO_CACHE",
88+
"TURBO_TELEMETRY_DISABLED"
8189
]
8290
},
8391
"lint:js": {

0 commit comments

Comments
 (0)