Skip to content
This repository was archived by the owner on Feb 2, 2021. It is now read-only.

The app resources are un-bounded #53

Closed
sbose78 opened this issue Jan 14, 2019 · 5 comments
Closed

The app resources are un-bounded #53

sbose78 opened this issue Jan 14, 2019 · 5 comments
Labels

Comments

@sbose78
Copy link

sbose78 commented Jan 14, 2019

Is it fine if we fix the resource limits for this booster to something like

         resources:
            requests:
              cpu: 150m
              memory: 256Mi
            limits:
              cpu: 300m
              memory: 512Mi
@lholmquist
Copy link
Contributor

That is probably fine. I've always run this on my local env, so i've never really needed to think to much about the resources, but i know you guys are running this on an instance with limited resources, so if you want to send a PR, i'll merge it in

@sbose78
Copy link
Author

sbose78 commented Jan 14, 2019

Thanks @lholmquist for the quick response! Will send a tested PR soon.

@sbose78
Copy link
Author

sbose78 commented Jan 14, 2019

@lholmquist , Filed the issue here by mistake. We would like to fix this for the community booster https://github.com/nodeshift-starters/nodejs-rest-http-crud Are you OK with that, as well?

@lholmquist
Copy link
Contributor

@sbose78 yea, lets do both

@lholmquist
Copy link
Contributor

should be in the code base now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants