Skip to content

Commit d5a48d1

Browse files
committed
amba-pl011: Don't send a character during startup
This causes a corrupted character to be sent and there's no explanation for why it is required. If it worked correctly it would send an extra 0x00 which isn't appropriate either. Signed-off-by: Simon Arlott <sa.me.uk>
1 parent cc77aa1 commit d5a48d1

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

drivers/tty/serial/amba-pl011.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1338,6 +1338,11 @@ static int pl011_startup(struct uart_port *port)
13381338

13391339
writew(uap->vendor->ifls, uap->port.membase + UART011_IFLS);
13401340

1341+
/*
1342+
* The write to UART01x_DR causes a corrupted character to be sent
1343+
* - why is it required?
1344+
*/
1345+
#if 0
13411346
/*
13421347
* Provoke TX FIFO interrupt into asserting.
13431348
*/
@@ -1359,6 +1364,7 @@ static int pl011_startup(struct uart_port *port)
13591364
writew(0, uap->port.membase + UART01x_DR);
13601365
while (readw(uap->port.membase + UART01x_FR) & UART01x_FR_BUSY)
13611366
barrier();
1367+
#endif
13621368

13631369
/* restore RTS and DTR */
13641370
cr = uap->old_cr & (UART011_CR_RTS | UART011_CR_DTR);

0 commit comments

Comments
 (0)