fix: replace deprecated null_data_source with locals (#336)

Michenux · Laurent Michenaud · npalm · web-flow · commit 6a240c9078a5 · 2021-07-08T22:17:20.000+02:00
* fix: replace deprecated null_data_source with locals

* fix: indentation

* fix: indentation

Co-authored-by: Laurent Michenaud &lt;laurent.michenaud@external.grtgaz.com&gt;
Co-authored-by: Niek Palm &lt;npalm@users.noreply.github.com&gt;
diff --git a/.gitignore b/.gitignore
@@ -3,6 +3,7 @@
 
 # Module directory
 .terraform/
+.terraform.lock.hcl
 
 # keys
 *id_rsa*
diff --git a/main.tf b/main.tf
@@ -164,7 +164,7 @@ resource "aws_autoscaling_group" "gitlab_runner_instance" {
   health_check_grace_period = 0
   launch_configuration      = aws_launch_configuration.gitlab_runner_instance.name
   enabled_metrics           = var.metrics_autoscaling
-  tags                      = [for key, value in local.agent_tags : tomap({ "key" : key, "value" : value, "propagate_at_launch" : true })]
+  tags                      = local.agent_tags_propagated
 
   timeouts {
     delete = var.asg_delete_timeout
diff --git a/tags.tf b/tags.tf
@@ -19,6 +19,7 @@ locals {
     var.tags,
     var.agent_tags
   )
+  agent_tags_propagated = [for tag_key, tag_value in local.agent_tags : { key = tag_key, value = tag_value, propagate_at_launch = true }]
 
   tags_string = join(",", flatten([
     for key in keys(local.tags) : [key, lookup(local.tags, key)]

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@ locals {`
`19`	`19`	`var.tags,`
`20`	`20`	`var.agent_tags`
`21`	`21`	`)`
	`22`	`+ agent_tags_propagated = [for tag_key, tag_value in local.agent_tags : { key = tag_key, value = tag_value, propagate_at_launch = true }]`
`22`	`23`
`23`	`24`	`tags_string = join(",", flatten([`
`24`	`25`	`for key in keys(local.tags) : [key, lookup(local.tags, key)]`