Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker machine defaults to aarch64, best to make to autodetect? #299

Closed
rtoma opened this issue Feb 17, 2021 · 3 comments
Closed

docker machine defaults to aarch64, best to make to autodetect? #299

rtoma opened this issue Feb 17, 2021 · 3 comments

Comments

@rtoma
Copy link

rtoma commented Feb 17, 2021

Wondering why the default docker_machine_download_url defaults to the aarch64 binary. Note the description mentions x64.

variable "docker_machine_download_url" {
  description = "Full url pointing to a linux x64 distribution of docker machine. Once set `docker_machine_version` will be ingored. For example the GitLab version, https://gitlab-docker-machine-downloads.s3.amazonaws.com/v0.16.2-gitlab.2/docker-machine."
  type        = string
  default     = "https://gitlab-docker-machine-downloads.s3.amazonaws.com/v0.16.2-gitlab.10/docker-machine-Linux-aarch64"
}

Maybe best to default docker_machine_download_url to "" and add a default docker_machine_version value? That way the template/gitlab-runner.tpl will download the appropriate arch and code will work for more users. Thanks!

@npalm
Copy link
Collaborator

npalm commented Mar 4, 2021

The default should point to the x64 versions, since the default is also m5.arge

@npalm
Copy link
Collaborator

npalm commented Mar 4, 2021

I configure it always expicit like https://github.com/npalm/terraform-aws-gitlab-runner/blob/develop/examples/runner-default/main.tf so completely missed the bug

@npalm
Copy link
Collaborator

npalm commented Mar 11, 2021

I will set the default URL to https://gitlab-docker-machine-downloads.s3.amazonaws.com/v0.16.2-gitlab.2/docker-machine So it supports the default settings

npalm added a commit that referenced this issue Mar 11, 2021
npalm added a commit that referenced this issue Mar 11, 2021
npalm added a commit that referenced this issue Mar 11, 2021
npalm added a commit that referenced this issue Mar 11, 2021
npalm added a commit that referenced this issue Mar 11, 2021
semantic-releaser bot pushed a commit that referenced this issue Mar 11, 2021
### [4.24.1](4.24.0...4.24.1) (2021-03-11)

### Bug Fixes

* updated docker machine default url ([064e0e2](064e0e2)), closes [#308](#308) [#299](#299)
@npalm npalm closed this as completed Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants