Skip to content

feat: Add ability to specify extra security group IDs for the runner agent #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2021
Merged

feat: Add ability to specify extra security group IDs for the runner agent #378

merged 1 commit into from
Oct 8, 2021

Conversation

ryancausey
Copy link
Contributor

Description

Add ability to specify extra security group IDs for the runner agent

Migrations required

NO

Verification

Tested using the "docker" executor and "docker+machine" executor that the extra security groups are associated with the runner agent instance.

Documentation

Ran pre-commit hook. It changed a lot in the README.md so I'm not sure if it ran correctly or not.

Copy link
Collaborator

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small comment

@ryancausey ryancausey requested a review from npalm October 8, 2021 01:06
@npalm npalm merged commit e0370dd into cattle-ops:develop Oct 8, 2021
semantic-releaser bot pushed a commit that referenced this pull request Oct 8, 2021
## [4.32.0](4.31.1...4.32.0) (2021-10-08)

### Features

* Add ability to specify extra security group IDs for the runner agent ([#378](#378)) ([e0370dd](e0370dd))

### Bug Fixes

* upgrade dependencies ([#379](#379)) ([daf5ee0](daf5ee0))
@semantic-releaser
Copy link
Contributor

🎉 This PR is included in version 4.32.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants