Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating aws_cloudwatch_log_group name to match the custom one provid… #384

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

mgomezzul
Copy link
Contributor

Fix custom log_group_name usage

Description

When you pass the log_group_name terraform input variable the expected behavior is to create this
log_group_name but it still creating the one with environment variable name.

Migrations required

NO

Verification

resource "aws_cloudwatch_log_group" "environment" {
  count             = var.enable_cloudwatch_logging ? 1 : 0
  name              = var.log_group_name != null ? var.log_group_name : var.environment
  retention_in_days = var.cloudwatch_logging_retention_in_days
  tags              = local.tags
  kms_key_id        = local.kms_key
}

Documentation

We use pre-commit to update the Terraform inputs and outputs in the documentation via terraform-docs. Ensure you have installed those components.

Copy link
Collaborator

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@npalm npalm merged commit d2a3de9 into cattle-ops:develop Oct 13, 2021
npalm pushed a commit that referenced this pull request Oct 13, 2021
… variable log_group_name (#384)

Co-authored-by: Mateo Gómez-Zuluaga <[email protected]>
semantic-releaser bot pushed a commit that referenced this pull request Oct 13, 2021
## [4.34.0](4.33.0...4.34.0) (2021-10-13)

### Features

* Add support ASG maximum instance lifetime ([#385](#385)) ([8515137](8515137))

### Bug Fixes

* aws_cloudwatch_log_group name to match the custom one provide by variable log_group_name ([#384](#384)) ([f80accd](f80accd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants