feat: Add option to specify prometheus metrics listen address #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayman-mk
reviewed
May 6, 2022
.pre-commit-config.yaml
Outdated
| @@ -1,12 +1,13 @@ | |||
| repos: | |||
| - repo: git://github.com/antonbabenko/pre-commit-terraform | |||
| - repo: http://github.com/antonbabenko/pre-commit-terraform | |||
There was a problem hiding this comment.
question: checked in by accident?
There was a problem hiding this comment.
Just had the same issue. The git protocol is outdated. See #481
There was a problem hiding this comment.
Should it not be https instead of http?
mmoutama09
force-pushed
the
add_prometheus_metrics
branch
from
38128ab to
1c589c0
Compare
npalm
requested changes
May 16, 2022
There was a problem hiding this comment.
@mmoutama09 thanks for your contribution, sorry for keep you wainting. Just a small remark on the pre-commit. Can you update it to https?
.pre-commit-config.yaml
Outdated
| @@ -1,12 +1,13 @@ | |||
| repos: | |||
| - repo: git://github.com/antonbabenko/pre-commit-terraform | |||
| - repo: http://github.com/antonbabenko/pre-commit-terraform | |||
There was a problem hiding this comment.
Should it not be https instead of http?
|
Just merged #481 fixing the submodule |
npalm
approved these changes
May 16, 2022
npalm
changed the title
semantic-releaser bot
pushed a commit
that referenced
this pull request
May 16, 2022
## [4.42.0](4.41.1...4.42.0) (2022-05-16) ### Features * Add option to specify prometheus metrics listen address [#478](#478) ([d441e27](d441e27)) * support runner AuthenticationType configuration ([7d3617e](7d3617e)) ### Bug Fixes * join the volumes with \n instead of , ([#480](#480)) ([f9de728](f9de728))
|
🎉 This PR is included in version 4.42.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add variable listen_address to enable prometheus metrics
Migrations required
NO
Verification
plan is joined to the PR
plan.txt