Skip to content

feat(asg): Add fine-grained options for schedule_config scale_in and scale_out #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

baolsen
Copy link
Contributor

@baolsen baolsen commented Dec 1, 2022

Description

Closes #585

Migrations required

NO

Verification

None. I've locally tested the "try" logic in terraform console to ensure it works with / without the overrides.

@baolsen baolsen force-pushed the asg-fine-grained-control branch from 7920a4f to d1d34c4 Compare December 1, 2022 09:43
@kayman-mk
Copy link
Collaborator

Nice! Have never noticed this schedule_config before.

@kayman-mk
Copy link
Collaborator

Could you please run a terraform apply with a dummy example? Just to make sure that the module is still deployable. Code looks good.

Copy link
Collaborator

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what the change is solving. It seems only defaults are changed which can be done by setting a variable to your need.

@baolsen
Copy link
Contributor Author

baolsen commented Dec 6, 2022

Thanks for the feedback @npalm , the "actual" change is in main.tf and addresses the issue #585

Specifically, when the values for min_size, max_size and desired_capacity need to be different from one another - current functionality only allows setting them all to the same value (specified by xxx_count).

@baolsen baolsen force-pushed the asg-fine-grained-control branch from d1d34c4 to 75f57d7 Compare December 7, 2022 13:29
@npalm npalm requested a review from kayman-mk December 8, 2022 19:41
@npalm npalm merged commit f72b8e3 into cattle-ops:develop Dec 11, 2022
This was referenced Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Support more fine-grained control over ASG scaling
3 participants