fix: error IAM role attachement when applying the module the first ti… #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kayman-mk would you the option to rebase this PR |
|
Merge conflicts solved. I changed some more policies and tested the change. First apply succeeded. 👍 |
kayman-mk
requested changes
Jan 19, 2023
kayman-mk
requested changes
Jan 19, 2023
Co-authored-by: Matthias Kay <[email protected]>
|
@kayman-mk accepted your suggestion, PR is good to go. Please can you review the PR? |
|
@kayman-mk can you review the PR, should be ready to merge |
kayman-mk
approved these changes
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #591
Ensure policies attachment are done with module managed resources in case the role is managed via terraform objects. This to avoid attachments are created before the role is created. Depends on does not support dynamics, sot not an option.
Migrations required
NO
Verification