Skip to content

Commit 235ed1d

Browse files
G-Rathclaudiahdz
authored andcommitted
Don't override user specified depth in outdated
Restores ability to update packages using `--depth` as suggested by `npm audit`. i.e `npm update eslint-utils --depth 2`. PR-URL: #239 Credit: @G-Rath Close: #239 Reviewed-by: @claudiahdz
1 parent bd6e5d2 commit 235ed1d

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

lib/outdated.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ function outdated (args, silent, cb) {
9191
var dir = path.resolve(npm.dir, '..')
9292

9393
// default depth for `outdated` is 0 (cf. `ls`)
94-
if (opts.depth) opts = opts.concat({depth: 0})
94+
if (opts.depth === Infinity) opts = opts.concat({depth: 0})
9595

9696
readPackageTree(dir, andComputeMetadata(function (er, tree) {
9797
if (!tree) return cb(er)

test/tap/outdated-depth.js

+14-3
Original file line numberDiff line numberDiff line change
@@ -47,19 +47,30 @@ test('outdated depth zero', function (t) {
4747
mr({ port: common.port }, function (er, s) {
4848
npm.load(
4949
{
50+
depth: 0,
5051
loglevel: 'silent',
5152
registry: common.registry
5253
},
5354
function () {
5455
npm.install('.', function (er) {
5556
if (er) throw new Error(er)
5657
npm.outdated(function (err, d) {
57-
t.ifError(err, 'npm outdated ran without error')
58+
if (err) {
59+
throw err
60+
}
5861
t.is(process.exitCode, 1, 'exit code set to 1')
5962
process.exitCode = 0
6063
t.deepEqual(d[0], expected)
61-
s.close()
62-
t.end()
64+
t.equal(d.length, 1)
65+
npm.config.set('depth', 1)
66+
npm.outdated(function (err, d) {
67+
t.equal(d.length, 2)
68+
if (err) {
69+
throw err
70+
}
71+
s.close()
72+
t.end()
73+
})
6374
})
6475
})
6576
}

0 commit comments

Comments
 (0)