feat: move nerfDart list into @npmcli/config

Author: wraithgar

lib/commands/config.js

@@ -4,23 +4,11 @@ const { spawn } = require('node:child_process')
 const { EOL } = require('node:os')
 const localeCompare = require('@isaacs/string-locale-compare')('en')
 const pkgJson = require('@npmcli/package-json')
-const { defaults, definitions } = require('@npmcli/config/lib/definitions')
+const { defaults, definitions, nerfDarts } = require('@npmcli/config/lib/definitions')
 const { log, output } = require('proc-log')
 const BaseCommand = require('../base-cmd.js')
 const { redact } = require('@npmcli/redact')
 
-// These are the configs that we can nerf-dart. Not all of them currently even
-// *have* config definitions so we have to explicitly validate them here.
-// This is used to validate during "npm config set"
-const nerfDarts = [
-  '_auth',
-  '_authToken',
-  '_password',
-  'certfile',
-  'email',
-  'keyfile',
-  'username',
-]
 // These are the config values to swap with "protected".  It does not catch
 // every single sensitive thing a user may put in the npmrc file but it gets
 // the common ones.  This is distinct from nerfDarts because that is used to
@@ -125,7 +113,7 @@ class Config extends BaseCommand {
     const action = argv[2]
     switch (action) {
       case 'set':
-        // todo: complete with valid values, if possible.
+        // TODO: complete with valid values, if possible.
         if (argv.length > 3) {
           return []
         }

lib/npm.js

@@ -2,7 +2,7 @@ const { resolve, dirname, join } = require('node:path')
 const Config = require('@npmcli/config')
 const which = require('which')
 const fs = require('node:fs/promises')
-const { definitions, flatten, shorthands } = require('@npmcli/config/lib/definitions')
+const { definitions, flatten, nerfDarts, shorthands } = require('@npmcli/config/lib/definitions')
 const usage = require('./utils/npm-usage.js')
 const LogFile = require('./utils/log-file.js')
 const Timers = require('./utils/timers.js')
@@ -68,6 +68,7 @@ class Npm {
       npmPath: this.#npmRoot,
       definitions,
       flatten,
+      nerfDarts,
       shorthands,
       argv: [...process.argv, ...argv],
       excludeNpmCwd,

workspaces/config/lib/definitions/index.js

@@ -58,9 +58,22 @@ const shorthands = {
   ...definitionProps.shorthands,
 }
 
+// These are the configs that we can nerf-dart. Only _auth even has a config definition so we have to explicitly validate them here.
+// This is used to validate during "npm config set" and to not warn on loading unknown configs when we see these.
+const nerfDarts = [
+  '_auth', // Has a config
+  '_authToken', // Does not have a config
+  '_password', // Does not have a config
+  'certfile', // Does not have a config
+  'email', // Does not have a config
+  'keyfile', // Does not have a config
+  'username', // Does not have a config
+]
+
 module.exports = {
   defaults: definitionProps.defaults,
   definitions,
   flatten,
+  nerfDarts,
   shorthands,
 }

workspaces/config/lib/index.js

@@ -61,6 +61,7 @@ class Config {
     definitions,
     shorthands,
     flatten,
+    nerfDarts = [],
     npmPath,
 
     // options just to override in tests, mostly
@@ -71,8 +72,9 @@ class Config {
     cwd = process.cwd(),
     excludeNpmCwd = false,
   }) {
-    // turn the definitions into nopt's weirdo syntax
+    this.nerfDarts = nerfDarts
     this.definitions = definitions
+    // turn the definitions into nopt's weirdo syntax
     const types = {}
     const defaults = {}
     this.deprecated = {}
@@ -572,7 +574,6 @@ class Config {
   }
 
   #checkDeprecated (key) {
-    // XXX(npm9+) make this throw an error
     if (this.deprecated[key]) {
       log.warn('config', key, this.deprecated[key])
     }