Skip to content
This repository was archived by the owner on Aug 11, 2021. It is now read-only.

Commit 9da90e3

Browse files
committed
dep: remove mkdirp dependency
* dep: mkdirp hasn't been updated in 4 years, and node's fs library has had a recursive option for `fs` since v10.12 (oldest active LTS version). Additionally `mkdirp` depends on a version of library `minimist` that has a minor vulnerability associated. Refs: * https://nodejs.org/api/fs.html#fs_fs_mkdir_path_options_callback * https://npmjs.com/advisories/1179
1 parent bffea43 commit 9da90e3

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

lib/dir-writer.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
module.exports = DirWriter
88

99
var Writer = require('./writer.js')
10+
var nodeFs = require('fs')
1011
var inherits = require('inherits')
11-
var mkdir = require('mkdirp')
1212
var path = require('path')
1313
var collect = require('./collect.js')
1414

@@ -31,7 +31,7 @@ function DirWriter (props) {
3131

3232
DirWriter.prototype._create = function () {
3333
var self = this
34-
mkdir(self._path, Writer.dirmode, function (er) {
34+
nodeFs.mkdir(self._path, { recursive: true }, function (er) {
3535
if (er) return self.error(er)
3636
// ready to start getting entries!
3737
self.ready = true

lib/writer.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
module.exports = Writer
22

3+
var nodeFs = require('fs')
34
var fs = require('graceful-fs')
45
var inherits = require('inherits')
56
var rimraf = require('rimraf')
6-
var mkdir = require('mkdirp')
77
var path = require('path')
88
var umask = process.platform === 'win32' ? 0 : process.umask()
99
var getType = require('./get-type.js')
@@ -166,7 +166,7 @@ function create (self) {
166166

167167
// XXX Need to clobber non-dirs that are in the way,
168168
// unless { clobber: false } in the props.
169-
mkdir(path.dirname(self._path), Writer.dirmode, function (er, made) {
169+
nodeFs.mkdir(path.dirname(self._path), { recursive: true }, function (er, made) {
170170
// console.error("W created", path.dirname(self._path), er)
171171
if (er) return self.error(er)
172172

package-lock.json

+5-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
"dependencies": {
1515
"graceful-fs": "^4.1.2",
1616
"inherits": "~2.0.0",
17-
"mkdirp": "^0.5 0",
1817
"rimraf": "2"
1918
},
2019
"devDependencies": {

0 commit comments

Comments
 (0)