Skip to content

Diff should consider pre only on greater version #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mick62 opened this issue Mar 17, 2022 · 1 comment
Closed

Diff should consider pre only on greater version #440

mick62 opened this issue Mar 17, 2022 · 1 comment

Comments

@mick62
Copy link

mick62 commented Mar 17, 2022

The "diff" function should report the level of the highest prio difference.
When comparing "1.1.1-foo" to "1.1.2" the fact that the first is a pre-build is not of interest because the second is a regular version, i.e. the relevant change is on patch level.
Hence the result should be "patch", not "prepatch".
When comparing "1.1.1" to "1.1.2-foo" the relevant change is on patch level but with the caveat that the second is a pre-release version.
Hence only in this case the result should be (as it is now) "prepatch".

@mick62 mick62 changed the title Diff should consider pre only on greater side Diff should consider pre only on greater version Mar 17, 2022
@lukekarrys
Copy link
Contributor

Closing as a duplicate of #333.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants