Skip to content

Commit 817d49e

Browse files
lukekarryslukekarrys
committed
fix: remove 'All' from regular test job name
1 parent 2abf443 commit 817d49e

File tree

8 files changed

+22
-22
lines changed

8 files changed

+22
-22
lines changed

‎.github/workflows/ci-release.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ jobs:
6767
check_id: ${{ steps.check.outputs.check_id }}
6868

6969
test-all:
70-
name: Test All - ${{ matrix.platform.name }} - Node ${{ matrix.node-version }}
70+
name: Test All - ${{ matrix.platform.name }} - ${{ matrix.node-version }}
7171
if: github.repository_owner == 'npm'
7272
strategy:
7373
fail-fast: false
@@ -101,7 +101,7 @@ jobs:
101101
with:
102102
token: ${{ secrets.GITHUB_TOKEN }}
103103
status: in_progress
104-
name: Test All - ${{ matrix.platform.name }} - Node ${{ matrix.node-version }}
104+
name: Test All - ${{ matrix.platform.name }} - ${{ matrix.node-version }}
105105
sha: ${{ inputs.check-sha }}
106106
# XXX: this does not work when using the default GITHUB_TOKEN.
107107
# Instead we post the main job url to the PR as a comment which

‎.github/workflows/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
run: npm run postlint --ignore-scripts
4545

4646
test:
47-
name: Test All - ${{ matrix.platform.name }} - Node ${{ matrix.node-version }}
47+
name: Test - ${{ matrix.platform.name }} - ${{ matrix.node-version }}
4848
if: github.repository_owner == 'npm'
4949
strategy:
5050
fail-fast: false

‎lib/content/_job-matrix.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: {{ jobName }}
1+
name: {{ jobName }} - $\{{ matrix.platform.name }} - $\{{ matrix.node-version }}
22
if: github.repository_owner == 'npm'
33
strategy:
44
fail-fast: false
@@ -26,4 +26,4 @@ defaults:
2626
run:
2727
shell: $\{{ matrix.platform.shell }}
2828
steps:
29-
{{> stepsSetup jobNodeMatrix=true }}
29+
{{> stepsSetup jobIsMatrix=true }}

‎lib/content/_step-checks.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
token: $\{{ secrets.GITHUB_TOKEN }}
1111
{{#if jobCheck.sha}}
1212
status: {{#if jobCheck.status}}{{ jobCheck.status }}{{else}}in_progress{{/if}}
13-
name: {{#if jobCheck.name}}{{ jobCheck.name }}{{else}}{{ jobName }}{{/if}}
13+
name: {{#if jobCheck.name}}{{ jobCheck.name }}{{else}}{{ jobName }}{{/if}}{{#if jobIsMatrix}} - $\{{ matrix.platform.name }} - $\{{ matrix.node-version }}{{/if}}
1414
sha: {{ jobCheck.sha }}
1515
# XXX: this does not work when using the default GITHUB_TOKEN.
1616
# Instead we post the main job url to the PR as a comment which

‎lib/content/_step-node.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
- name: Setup Node
22
uses: actions/setup-node@v3
33
with:
4-
node-version: {{#if jobNodeMatrix}}$\{{ matrix.node-version }}{{else}}{{ last ciVersions }}{{/if}}
4+
node-version: {{#if jobIsMatrix}}$\{{ matrix.node-version }}{{else}}{{ last ciVersions }}{{/if}}
55
{{#if lockfile}}
66
cache: npm
77
{{/if}}
88
{{#if updateNpm}}
9-
{{#if jobNodeMatrix}}
9+
{{#if jobIsMatrix}}
1010
- name: Update Windows npm
1111
# node 12 and 14 ship with npm@6, which is known to fail when updating itself in windows
1212
if: matrix.platform.os == 'windows-latest' && (startsWith(matrix.node-version, '12.') || startsWith(matrix.node-version, '14.'))

‎lib/content/ci-release.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323

2424
test-all:
2525
{{> jobMatrix
26-
jobName="Test All - ${{ matrix.platform.name }} - Node ${{ matrix.node-version }}"
26+
jobName="Test All"
2727
jobCheck=(obj sha="${{ inputs.check-sha }}")
2828
jobCheckout=(obj ref="${{ inputs.ref }}")
2929
}}

‎lib/content/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ jobs:
99
{{> stepLint jobRunFlags=pkgFlags }}
1010

1111
test:
12-
{{> jobMatrix jobName="Test All - ${{ matrix.platform.name }} - Node ${{ matrix.node-version }}" }}
12+
{{> jobMatrix jobName="Test" }}
1313
{{> stepTest jobRunFlags=pkgFlags }}

‎tap-snapshots/test/apply/source-snapshots.js.test.cjs

+12-12
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ jobs:
274274
check_id: \${{ steps.check.outputs.check_id }}
275275
276276
test-all:
277-
name: Test All - \${{ matrix.platform.name }} - Node \${{ matrix.node-version }}
277+
name: Test All - \${{ matrix.platform.name }} - \${{ matrix.node-version }}
278278
if: github.repository_owner == 'npm'
279279
strategy:
280280
fail-fast: false
@@ -308,7 +308,7 @@ jobs:
308308
with:
309309
token: \${{ secrets.GITHUB_TOKEN }}
310310
status: in_progress
311-
name: Test All - \${{ matrix.platform.name }} - Node \${{ matrix.node-version }}
311+
name: Test All - \${{ matrix.platform.name }} - \${{ matrix.node-version }}
312312
sha: \${{ inputs.check-sha }}
313313
# XXX: this does not work when using the default GITHUB_TOKEN.
314314
# Instead we post the main job url to the PR as a comment which
@@ -408,7 +408,7 @@ jobs:
408408
run: npm run postlint --ignore-scripts
409409
410410
test:
411-
name: Test All - \${{ matrix.platform.name }} - Node \${{ matrix.node-version }}
411+
name: Test - \${{ matrix.platform.name }} - \${{ matrix.node-version }}
412412
if: github.repository_owner == 'npm'
413413
strategy:
414414
fail-fast: false
@@ -1322,7 +1322,7 @@ jobs:
13221322
run: npm run postlint --ignore-scripts
13231323
13241324
test:
1325-
name: Test All - \${{ matrix.platform.name }} - Node \${{ matrix.node-version }}
1325+
name: Test - \${{ matrix.platform.name }} - \${{ matrix.node-version }}
13261326
if: github.repository_owner == 'npm'
13271327
strategy:
13281328
fail-fast: false
@@ -1436,7 +1436,7 @@ jobs:
14361436
run: npm run postlint --ignore-scripts
14371437
14381438
test:
1439-
name: Test All - \${{ matrix.platform.name }} - Node \${{ matrix.node-version }}
1439+
name: Test - \${{ matrix.platform.name }} - \${{ matrix.node-version }}
14401440
if: github.repository_owner == 'npm'
14411441
strategy:
14421442
fail-fast: false
@@ -1569,7 +1569,7 @@ jobs:
15691569
check_id: \${{ steps.check.outputs.check_id }}
15701570
15711571
test-all:
1572-
name: Test All - \${{ matrix.platform.name }} - Node \${{ matrix.node-version }}
1572+
name: Test All - \${{ matrix.platform.name }} - \${{ matrix.node-version }}
15731573
if: github.repository_owner == 'npm'
15741574
strategy:
15751575
fail-fast: false
@@ -1603,7 +1603,7 @@ jobs:
16031603
with:
16041604
token: \${{ secrets.GITHUB_TOKEN }}
16051605
status: in_progress
1606-
name: Test All - \${{ matrix.platform.name }} - Node \${{ matrix.node-version }}
1606+
name: Test All - \${{ matrix.platform.name }} - \${{ matrix.node-version }}
16071607
sha: \${{ inputs.check-sha }}
16081608
# XXX: this does not work when using the default GITHUB_TOKEN.
16091609
# Instead we post the main job url to the PR as a comment which
@@ -1705,7 +1705,7 @@ jobs:
17051705
run: npm run postlint --ignore-scripts
17061706
17071707
test:
1708-
name: Test All - \${{ matrix.platform.name }} - Node \${{ matrix.node-version }}
1708+
name: Test - \${{ matrix.platform.name }} - \${{ matrix.node-version }}
17091709
if: github.repository_owner == 'npm'
17101710
strategy:
17111711
fail-fast: false
@@ -2621,7 +2621,7 @@ jobs:
26212621
run: npm run postlint --ignore-scripts
26222622
26232623
test:
2624-
name: Test All - \${{ matrix.platform.name }} - Node \${{ matrix.node-version }}
2624+
name: Test - \${{ matrix.platform.name }} - \${{ matrix.node-version }}
26252625
if: github.repository_owner == 'npm'
26262626
strategy:
26272627
fail-fast: false
@@ -2735,7 +2735,7 @@ jobs:
27352735
run: npm run postlint --ignore-scripts
27362736
27372737
test:
2738-
name: Test All - \${{ matrix.platform.name }} - Node \${{ matrix.node-version }}
2738+
name: Test - \${{ matrix.platform.name }} - \${{ matrix.node-version }}
27392739
if: github.repository_owner == 'npm'
27402740
strategy:
27412741
fail-fast: false
@@ -2868,7 +2868,7 @@ jobs:
28682868
check_id: \${{ steps.check.outputs.check_id }}
28692869
28702870
test-all:
2871-
name: Test All - \${{ matrix.platform.name }} - Node \${{ matrix.node-version }}
2871+
name: Test All - \${{ matrix.platform.name }} - \${{ matrix.node-version }}
28722872
if: github.repository_owner == 'npm'
28732873
strategy:
28742874
fail-fast: false
@@ -2902,7 +2902,7 @@ jobs:
29022902
with:
29032903
token: \${{ secrets.GITHUB_TOKEN }}
29042904
status: in_progress
2905-
name: Test All - \${{ matrix.platform.name }} - Node \${{ matrix.node-version }}
2905+
name: Test All - \${{ matrix.platform.name }} - \${{ matrix.node-version }}
29062906
sha: \${{ inputs.check-sha }}
29072907
# XXX: this does not work when using the default GITHUB_TOKEN.
29082908
# Instead we post the main job url to the PR as a comment which

0 commit comments

Comments
 (0)