-
Notifications
You must be signed in to change notification settings - Fork 97
[Feature Request] Allow to disable console logging or allow to provide custom logger #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I was just looking to solve the same problem. It would be nice to be able to separate these concerns. |
@holm for now I have a temp workaround in my project:
Definetely worth a try to fork the repo, get rid of inheritance and do a PR. Rather than extending |
Awesome. Thanks for doing that. Added a few comments on the PR, just from my perspective, although of course this is not my library at all :) |
Looks like by using the instance directly, it doesn't log into the console. So using: |
Hey!
In my Nest project I have a custom Logger implementation which is optimized for SumoLogic format. In case of errors I use my logger to print logs and
@ntegral/nestjs-sentry
to send error to Sentry. The problem is that lib by default also prints logs in default Nest format because ofSentryService extends ConsoleLogger
.I would to have an ability to
disable
that default behaviour in order to keep my logs clean and without duplication.Or, as another solution, would be great to have an ability to provide own custom logger to
@ntegral/nestjs-sentry
.What do you think about that?
The text was updated successfully, but these errors were encountered: