You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The package.json lists the dependency on @nestjs/graphql under optionalDependencies
I think the intention here was to express "if you use graphql, we are compatible with these versions." However, optionalDependencies is interpreted by npm to mean "install this if possible."
This means the only way to avoid a single optional dependency that is compatible with your engine is to suppress all of them with npm ci --no-optional, so if you add this package you get saddled with all the NestJS graphql packages in your node_modules even if you're not using them.
I think the ideal would be for the repository would publish two packages: @ntegral/nestjs-sentry and @ntegral/nestjs-sentry-graphql. The latter would have a peerDependency on the graphql packages and the former skipping any mention of graphql.
The text was updated successfully, but these errors were encountered:
This separates out two packages @travelerdev/nestjs-sentry and @travelerdev/nestjs-sentry-graphql which are identical except that the latter includes the peer dependency on the Nest Graphql package and exports the graphql interceptor, while the former doesn't.
(It also upgrades to NestJS 9.x support and Sentry 7.x)
Uh oh!
There was an error while loading. Please reload this page.
The package.json lists the dependency on
@nestjs/graphql
underoptionalDependencies
I think the intention here was to express "if you use graphql, we are compatible with these versions." However,
optionalDependencies
is interpreted bynpm
to mean "install this if possible."This means the only way to avoid a single optional dependency that is compatible with your engine is to suppress all of them with
npm ci --no-optional
, so if you add this package you get saddled with all the NestJS graphql packages in your node_modules even if you're not using them.I think the ideal would be for the repository would publish two packages:
@ntegral/nestjs-sentry
and@ntegral/nestjs-sentry-graphql
. The latter would have apeerDependency
on the graphql packages and the former skipping any mention of graphql.The text was updated successfully, but these errors were encountered: