Skip to content

Commit d153da8

Browse files
committed
Attempt to fix separator display when no result navigator.
Seems like there is a bug in Svelte which make $$slots.default being true even if the slot is not there. The code should work once sveltejs/svelte#8304 is fixed.
1 parent ea6adf5 commit d153da8

File tree

3 files changed

+9
-11
lines changed

3 files changed

+9
-11
lines changed

apps/search-widget-demo/src/App.svelte

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,11 @@
1515
let fieldType = 'file';
1616
let fieldId = '20fd69d4b4dcdf0eb9e8c95dfff1ce6c';
1717
18-
/**
19-
* Classifier_test kb (already trained, owned by Carmen): cbb4afd0-26e6-480a-a814-4e08398bdf3e
20-
* Kb with different kind of media (owned by Mat): 5c2bc432-a579-48cd-b408-4271e5e7a43c
21-
*/
22-
let kb = 'eda3f482-d432-4fac-913a-00f0a4696fd4'; // pdfs
18+
// let kb = 'eda3f482-d432-4fac-913a-00f0a4696fd4'; // pdfs
2319
// let kb = '5c2bc432-a579-48cd-b408-4271e5e7a43c'; // medias
2420
// let kb = 'f5d0ec7f-9ac3-46a3-b284-a38d5333d9e6'; // le petit prince
2521
// let kb = '49e0c43e-7beb-4418-94fa-ed90226f365c'; // la classe américaine
26-
// let kb = '89ffdada-58ee-4199-8303-ad1450de1cbe'; // word, excel, csv, images,…
22+
let kb = '89ffdada-58ee-4199-8303-ad1450de1cbe'; // word, excel, csv, images,…
2723
2824
onMount(() => {
2925
resultsWidget?.setTileMenu([

libs/search-widget/src/tiles/ImageTile.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
<BaseTile
2424
previewKind={PreviewKind.IMAGE}
2525
typeIndicator="image"
26-
noResultNavigator
26+
noResultNavigator={!result.paragraphs || result.paragraphs.length <= 1}
2727
{thumbnailLoaded}
2828
{result}
2929
on:selectParagraph={() => showImage()}>

libs/search-widget/src/tiles/base-tile/header/TileHeader.svelte

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
let menuPosition: { left: number; top: number } | undefined;
2424
let displayMenu = false;
2525
26-
$: hasActions = menuItems.length > 0;
26+
$: hasMenu = menuItems.length > 0;
2727
2828
onMount(() => {
2929
menuItems = getWidgetActions();
@@ -91,11 +91,13 @@
9191

9292
{#if expanded}
9393
<div class="header-actions">
94-
<slot />
95-
{#if $$slots.default && hasActions}
94+
{#if $$slots.default}
95+
<slot />
96+
{/if}
97+
{#if $$slots.default && hasMenu}
9698
<div class="separator" />
9799
{/if}
98-
{#if hasActions}
100+
{#if hasMenu}
99101
<div bind:this={menuButton}>
100102
<IconButton
101103
icon="more-vertical"

0 commit comments

Comments
 (0)