feat: migrate to immediate processing

Author: shikanime

cmd/format/format.go

@@ -167,6 +167,7 @@ func Run(v *viper.Viper, statz *stats.Stats, cmd *cobra.Command, paths []string)
 	// start traversing
 	files := make([]*walk.File, BatchSize)
 
+LOOP:
 	for {
 		// read the next batch
 		readCtx, cancel := context.WithTimeout(ctx, 1*time.Second)
@@ -180,17 +181,21 @@ func Run(v *viper.Viper, statz *stats.Stats, cmd *cobra.Command, paths []string)
 			return fmt.Errorf("formatting failure: %w", err)
 		}
 
-		if errors.Is(err, io.EOF) {
+		switch {
+		case errors.Is(err, io.EOF):
 			// we have finished traversing
-			break
-		} else if err != nil {
+			break LOOP
+		case cfg.Watch && errors.Is(err, context.DeadlineExceeded):
+			// we timed out reading files, try again
+			continue
+		case err != nil:
 			// something went wrong
 			return fmt.Errorf("failed to read files: %w", err)
 		}
 	}
 
 	// finalize formatting
-	formatErr := formatter.Close(ctx)
+	formatErr := formatter.Close()
 
 	// close the walker, ensuring any pending file release hooks finish
 	if err = walker.Close(); err != nil {

format/composite.go

@@ -107,6 +107,8 @@ func (c *CompositeFormatter) Apply(ctx context.Context, files []*walk.File) erro
 		}
 	}
 
+	c.scheduler.apply(ctx)
+
 	return nil
 }
 
@@ -136,8 +138,8 @@ func (c *CompositeFormatter) signature() (signature, error) {
 
 // Close finalizes the processing of the CompositeFormatter, ensuring that any remaining batches are applied and
 // all formatters have completed their tasks. It returns an error if any formatting failures were detected.
-func (c *CompositeFormatter) Close(ctx context.Context) error {
-	return c.scheduler.close(ctx)
+func (c *CompositeFormatter) Close() error {
+	return c.scheduler.close()
 }
 
 func NewCompositeFormatter(

format/scheduler.go

@@ -203,14 +203,16 @@ func (s *scheduler) schedule(ctx context.Context, key batchKey, batch []*walk.Fi
 	})
 }
 
-func (s *scheduler) close(ctx context.Context) error {
+func (s *scheduler) apply(ctx context.Context) {
 	// schedule any partial batches that remain
 	for key, batch := range s.batches {
 		if len(batch) > 0 {
 			s.schedule(ctx, key, batch)
 		}
 	}
+}
 
+func (s *scheduler) close() error {
 	// wait for processing to complete
 	if err := s.eg.Wait(); err != nil {
 		return fmt.Errorf("failed to wait for formatters: %w", err)