fix: use resolved executable when applying a formatter

brianmcgee · brianmcgee · commit 2b9448046151 · 2024-05-17T09:49:41.000+01:00
We were going to the trouble of resolving the command to an executable via the PATH but were not using that executable when executing the formatting command.

Signed-off-by: Brian McGee &lt;brian@bmcgee.ie&gt;
diff --git a/format/formatter.go b/format/formatter.go
@@ -80,7 +80,7 @@ func (f *Formatter) Apply(ctx context.Context, files []*walk.File, filter bool)
 	}
 
 	// execute the command
-	cmd := exec.CommandContext(ctx, f.config.Command, args...)
+	cmd := exec.CommandContext(ctx, f.executable, args...)
 	cmd.Dir = f.workingDir
 
 	if out, err := cmd.CombinedOutput(); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ func (f Formatter) Apply(ctx context.Context, files []walk.File, filter bool)`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`// execute the command`
`83`		`- cmd := exec.CommandContext(ctx, f.config.Command, args...)`
	`83`	`+ cmd := exec.CommandContext(ctx, f.executable, args...)`
`84`	`84`	`cmd.Dir = f.workingDir`
`85`	`85`
`86`	`86`	`if out, err := cmd.CombinedOutput(); err != nil {`