fix: Do not exclude executables in git walker

akshaymankar · akshaymankar · commit a5813527bb14 · 2024-08-21T10:14:17.000+02:00
diff --git a/walk/git.go b/walk/git.go
@@ -10,6 +10,7 @@ import (
 	"github.com/charmbracelet/log"
 
 	"github.com/go-git/go-git/v5"
+	"github.com/go-git/go-git/v5/plumbing/filemode"
 )
 
 type gitWalker struct {
@@ -52,7 +53,7 @@ func (g gitWalker) Walk(ctx context.Context, fn WalkFunc) error {
 					return ctx.Err()
 				default:
 					// we only want regular files, not directories or symlinks
-					if !entry.Mode.IsRegular() {
+					if entry.Mode == filemode.Dir || entry.Mode == filemode.Symlink {
 						continue
 					}
 

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@ import (`
`10`	`10`	`"github.com/charmbracelet/log"`
`11`	`11`
`12`	`12`	`"github.com/go-git/go-git/v5"`
	`13`	`+ "github.com/go-git/go-git/v5/plumbing/filemode"`
`13`	`14`	`)`
`14`	`15`
`15`	`16`	`type gitWalker struct {`
`@@ -52,7 +53,7 @@ func (g gitWalker) Walk(ctx context.Context, fn WalkFunc) error {`
`52`	`53`	`return ctx.Err()`
`53`	`54`	`default:`
`54`	`55`	`// we only want regular files, not directories or symlinks`
`55`		`- if !entry.Mode.IsRegular() {`
	`56`	`+ if entry.Mode == filemode.Dir \|\| entry.Mode == filemode.Symlink {`
`56`	`57`	`continue`
`57`	`58`	`}`
`58`	`59`