feat: update to go 1.24

- pins buildGoModule to buildGo124Module
- removes `toolchain` entry from `go.mod` as our toolchain is managed via Nix.
- cleans up devshell
- required adding no lint for chdir related code in test as golangci-lint was upgraded (we should use t.Chdir() on a first pass it was breaking the tests.
- ran a `nix fmt` which seems to have made minor changes to some markdown files

Signed-off-by: Brian McGee <[email protected]>

Author: brianmcgee

.github/workflows/release.yml

@@ -20,7 +20,7 @@ jobs:
             - name: Setup Go
               uses: actions/setup-go@v5
               with:
-                  go-version: 1.22.x
+                  go-version: 1.24.x
             - name: Run goreleaser
               uses: goreleaser/goreleaser-action@v6
               with:

.golangci.yml

@@ -3,12 +3,10 @@ linters:
     enable-all: true
     disable:
         - depguard
-        - execinquery
         - exhaustruct
-        - exportloopref
         - funlen
+        - tenv
         - godox
-        - gomnd
         - mnd
         - varnamelen
         - forbidigo

README.md

@@ -39,17 +39,17 @@ That's what treefmt is about.
 
 Its main features are:
 
--   **Providing a unified CLI and output**
-    -   You don’t need to remember which formatters are necessary for each project.
-    -   Once you specify the formatters in the config file, you can trigger all of them with one command and get a
-        standardized output.
--   **Running all the formatters in parallel**
-    -   A standard script loops over your folders and runs each formatter sequentially.
-    -   In contrast, `treefmt` runs formatters in parallel. This way, the formatting job takes less time.
--   **Tracking file changes**
-    -   When formatters are run in a script, they process all the files they encounter, regardless of whether or not
-        they have changed.
-    -   `treefmt` tracks file changes, and only attempts to format files which have changed.
+- **Providing a unified CLI and output**
+    - You don’t need to remember which formatters are necessary for each project.
+    - Once you specify the formatters in the config file, you can trigger all of them with one command and get a
+      standardized output.
+- **Running all the formatters in parallel**
+    - A standard script loops over your folders and runs each formatter sequentially.
+    - In contrast, `treefmt` runs formatters in parallel. This way, the formatting job takes less time.
+- **Tracking file changes**
+    - When formatters are run in a script, they process all the files they encounter, regardless of whether or not
+      they have changed.
+    - `treefmt` tracks file changes, and only attempts to format files which have changed.
 
 To reformat the whole source tree, just type `treefmt` in any folder. This is a fast and simple formatting solution.
 
@@ -124,31 +124,31 @@ formatters.
 
 For instance, you can go for:
 
--   [clang-format] for C/C++/Java/JavaScript/JSON/Objective-C/Protobuf/C#
--   gofmt for Golang
--   Prettier for JavaScript/HTML/CSS
+- [clang-format] for C/C++/Java/JavaScript/JSON/Objective-C/Protobuf/C#
+- gofmt for Golang
+- Prettier for JavaScript/HTML/CSS
 
 Find the full list of supported formatters [here](https://treefmt.com/configure.html#supported-formatters).
 
 ## IDE Integration
 
 `treefmt` currently has support for vscode via an extension:
 
--   [treefmt-vscode](https://marketplace.visualstudio.com/items?itemName=ibecker.treefmt-vscode) | [GitHub repo](https://github.com/isbecker/treefmt-vscode)
+- [treefmt-vscode](https://marketplace.visualstudio.com/items?itemName=ibecker.treefmt-vscode) | [GitHub repo](https://github.com/isbecker/treefmt-vscode)
 
 ## Upcoming features
 
 This project is still pretty new. Down the line we also want to add support for:
 
--   More IDE integration
--   Pre-commit hooks
+- More IDE integration
+- Pre-commit hooks
 
 ## Related projects
 
--   [EditorConfig](https://editorconfig.org/): unifies file indentations configuration on a per-project basis.
--   [prettier](https://prettier.io/): an opinionated code formatter for a number of languages.
--   [Super-Linter](https://github.com/github/super-linter): a project by GitHub to lint all of your code.
--   [pre-commit](https://pre-commit.com/): a framework for managing and maintaining multi-language pre-commit hooks.
+- [EditorConfig](https://editorconfig.org/): unifies file indentations configuration on a per-project basis.
+- [prettier](https://prettier.io/): an opinionated code formatter for a number of languages.
+- [Super-Linter](https://github.com/github/super-linter): a project by GitHub to lint all of your code.
+- [pre-commit](https://pre-commit.com/): a framework for managing and maintaining multi-language pre-commit hooks.
 
 ## Contributing
 

cmd/root_test.go

@@ -753,13 +753,15 @@ func TestChangeWorkingDirectory(t *testing.T) {
 		as.NoError(err)
 
 		t.Cleanup(func() {
+			//nolint:usetesting
 			// return to the previous working directory
 			as.NoError(os.Chdir(cwd))
 		})
 
 		tempDir := test.TempExamples(t)
 		configPath := filepath.Join(tempDir, "treefmt.toml")
 
+		//nolint:usetesting
 		// change to an empty temp dir and try running without specifying a working directory
 		as.NoError(os.Chdir(t.TempDir()))
 
@@ -770,6 +772,7 @@ func TestChangeWorkingDirectory(t *testing.T) {
 			}),
 		)
 
+		//nolint:usetesting
 		// now change to the examples temp directory
 		as.NoError(os.Chdir(tempDir), "failed to change to temp directory")
 
@@ -790,6 +793,7 @@ func TestChangeWorkingDirectory(t *testing.T) {
 			as.NoError(err)
 
 			t.Cleanup(func() {
+				//nolint:usetesting
 				// return to the previous working directory
 				as.NoError(os.Chdir(cwd))
 			})
@@ -1512,6 +1516,7 @@ func TestPathsArg(t *testing.T) {
 	as.NoError(err)
 
 	t.Cleanup(func() {
+		//nolint:usetesting
 		// return to the previous working directory
 		as.NoError(os.Chdir(cwd))
 	})
@@ -1529,6 +1534,7 @@ func TestPathsArg(t *testing.T) {
 	externalFile, err := os.Create(filepath.Join(tempDir, "outside_tree.go"))
 	as.NoError(err)
 
+	//nolint:usetesting
 	// change working directory to project root
 	as.NoError(os.Chdir(treeRoot))
 
@@ -1804,6 +1810,7 @@ func TestRunInSubdir(t *testing.T) {
 			err = os.Symlink(echoPath, echoRel)
 			as.NoError(err)
 
+			//nolint:usetesting
 			// change working directory to subdirectory
 			as.NoError(os.Chdir(filepath.Join(tempDir, "elm")))
 

docs/content/contributing/code.md

@@ -4,8 +4,8 @@
 
 You will need to have the following installed:
 
--   [Nix]
--   [Direnv]
+- [Nix]
+- [Direnv]
 
 !!! important
 

docs/content/contributing/docs.md

@@ -11,8 +11,8 @@ It can be entered by running: `nix develop .#docs`
 The docs are based on [MkDocs] and the [MkDocs Material] theme.
 You will find its configuration and content in the following locations:
 
--   `mkdocs.yaml`
--   `./docs`
+- `mkdocs.yaml`
+- `./docs`
 
 ## Serve locally
 
@@ -43,9 +43,9 @@ configured to serve from.
 There is a github workflow, `.github/workflows/gh-pages.yml` which is responsible for publishing the docs.
 It does the following:
 
--   On merge to `main`, the docs version [main](https://numtide.github.io/treefmt/main/) is updated.
--   When a new tag is created of the form `v.<major>.<minor>.<patch>` a docs version `v<major>.<minor>` is created and the
-    [latest](https://numtide.github.io/treefmt/latest) alias is updated to point to this.
+- On merge to `main`, the docs version [main](https://numtide.github.io/treefmt/main/) is updated.
+- When a new tag is created of the form `v.<major>.<minor>.<patch>` a docs version `v<major>.<minor>` is created and the
+  [latest](https://numtide.github.io/treefmt/latest) alias is updated to point to this.
 
 The idea is that users will land on the latest released version of the docs by default, with `main` being available if
 they wish to read about unreleased features and changes.

docs/content/getting-started/configure.md

@@ -332,9 +332,9 @@ File to search for to find the tree root (if `tree-root` is not set)
 
 Set the verbosity level of logs:
 
--   `0` => `warn`
--   `1` => `info`
--   `2` => `debug`
+- `0` => `warn`
+- `1` => `info`
+- `2` => `debug`
 
 === "Flag"
 
@@ -456,8 +456,8 @@ selectors such as `*` and `?`.
 
 ### Examples
 
--   `*.go` - match all files in the project that end with a ".go" file extension.
--   `vendor/*` - match all files under the vendor folder, recursively.
+- `*.go` - match all files in the project that end with a ".go" file extension.
+- `vendor/*` - match all files under the vendor folder, recursively.
 
 ## Supported Formatters
 

docs/content/reference/formatter-spec.md

@@ -29,9 +29,9 @@ The formatter's CLI must be of the form:
 
 Where:
 
--   `<command>` is the name of the formatting tool.
--   `[options]` is any number of flags and options that the formatter accepts.
--   `[...<files>]` is one or more files given to the formatter for processing.
+- `<command>` is the name of the formatting tool.
+- `[options]` is any number of flags and options that the formatter accepts.
+- `[...<files>]` is one or more files given to the formatter for processing.
 
 Example:
 

flake.lock

@@ -1,8 +1,6 @@
 module github.com/numtide/treefmt/v2
 
-go 1.23.0
-
-toolchain go1.24.1
+go 1.24
 
 require (
 	github.com/BurntSushi/toml v1.4.0
@@ -33,7 +31,6 @@ require (
 	github.com/mattn/go-isatty v0.0.20 // indirect
 	github.com/mattn/go-runewidth v0.0.15 // indirect
 	github.com/mitchellh/mapstructure v1.5.0 // indirect
-	github.com/muesli/cancelreader v0.2.2 // indirect
 	github.com/muesli/reflow v0.3.0 // indirect
 	github.com/muesli/termenv v0.15.2 // indirect
 	github.com/otiai10/mint v1.6.3 // indirect

go.mod

@@ -9,8 +9,8 @@ github.com/charmbracelet/lipgloss v0.10.0/go.mod h1:Wig9DSfvANsxqkRsqj6x87irdy12
 github.com/charmbracelet/log v0.4.0 h1:G9bQAcx8rWA2T3pWvx7YtPTPwgqpk7D68BX21IRW8ZM=
 github.com/charmbracelet/log v0.4.0/go.mod h1:63bXt/djrizTec0l11H20t8FDSvA4CRZJ1KH22MdptM=
 github.com/cpuguy83/go-md2man/v2 v2.0.6/go.mod h1:oOW0eioCTA6cOiMLiUPZOpcVxMig6NIQQ7OS05n1F4g=
-github.com/creack/pty v1.1.23 h1:4M6+isWdcStXEf15G/RbrMPOQj1dZ7HPZCGwE4kOeP0=
-github.com/creack/pty v1.1.23/go.mod h1:08sCNb52WyoAwi2QDyzUCTgcvVFhUzewun7wtTfvcwE=
+github.com/creack/pty v1.1.24 h1:bJrF4RRfyJnbTJqzRLHzcGaZK1NeM5kTC9jGgovnR1s=
+github.com/creack/pty v1.1.24/go.mod h1:08sCNb52WyoAwi2QDyzUCTgcvVFhUzewun7wtTfvcwE=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc h1:U9qPSI2PIWSS1VwoXQT9A3Wy9MM3WgvqSxFWenqJduM=
@@ -25,8 +25,8 @@ github.com/go-quicktest/qt v1.101.0 h1:O1K29Txy5P2OK0dGo59b7b0LR6wKfIhttaAhHUyn7
 github.com/go-quicktest/qt v1.101.0/go.mod h1:14Bz/f7NwaXPtdYEgzsx46kqSxVwTbzVZsDC26tQJow=
 github.com/gobwas/glob v0.2.3 h1:A4xDbljILXROh+kObIiy5kIaPYD8e96x1tgBhUI5J+Y=
 github.com/gobwas/glob v0.2.3/go.mod h1:d3Ez4x06l9bZtSvzIay5+Yzi0fmZzPgnTbPcKjJAkT8=
-github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
-github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
+github.com/google/go-cmp v0.7.0 h1:wk8382ETsv4JYUZwIsn6YpYiWiBsYLSJiTsyBybVuN8=
+github.com/google/go-cmp v0.7.0/go.mod h1:pXiqmnSA92OHEEa9HXL2W4E7lf9JzCmGVUdgjX3N/iU=
 github.com/hashicorp/hcl v1.0.0 h1:0Anlzjpi4vEasTeNFn2mLJgTSwt0+6sfsiTG8qcWGx4=
 github.com/hashicorp/hcl v1.0.0/go.mod h1:E5yfLk+7swimpb2L/Alb/PJmXilQ/rhwaUYs4T20WEQ=
 github.com/inconshreveable/mousetrap v1.1.0 h1:wN+x4NVGpMsO7ErUn/mUI3vEoE6Jt13X2s0bqwp9tc8=
@@ -49,8 +49,6 @@ github.com/mattn/go-runewidth v0.0.15 h1:UNAjwbU9l54TA3KzvqLGxwWjHmMgBUVhBiTjelZ
 github.com/mattn/go-runewidth v0.0.15/go.mod h1:Jdepj2loyihRzMpdS35Xk/zdY8IAYHsh153qUoGf23w=
 github.com/mitchellh/mapstructure v1.5.0 h1:jeMsZIYE/09sWLaz43PL7Gy6RuMjD2eJVyuac5Z2hdY=
 github.com/mitchellh/mapstructure v1.5.0/go.mod h1:bFUtVrKA4DC2yAKiSyO/QUcy7e+RRV2QTWOzhPopBRo=
-github.com/muesli/cancelreader v0.2.2 h1:3I4Kt4BQjOR54NavqnDogx/MIoWBFa0StPA8ELUXHmA=
-github.com/muesli/cancelreader v0.2.2/go.mod h1:3XuTXfFS2VjM+HTLZY9Ak0l6eUKfijIfMUZ4EgX0QYo=
 github.com/muesli/reflow v0.3.0 h1:IFsN6K9NfGtjeggFP+68I4chLZV2yIKsXJFNZ+eWh6s=
 github.com/muesli/reflow v0.3.0/go.mod h1:pbwTDkVPibjO2kyvBQRBxTWEEGDGq0FlB1BIKtnHY/8=
 github.com/muesli/termenv v0.15.2 h1:GohcuySI0QmI3wN8Ok9PtKGkgkFIk7y6Vpb5PvrY+Wo=
@@ -68,8 +66,8 @@ github.com/rivo/uniseg v0.1.0/go.mod h1:J6wj4VEh+S6ZtnVlnTBMWIodfgj8LQOQFoIToxlJ
 github.com/rivo/uniseg v0.2.0/go.mod h1:J6wj4VEh+S6ZtnVlnTBMWIodfgj8LQOQFoIToxlJtxc=
 github.com/rivo/uniseg v0.4.7 h1:WUdvkW8uEhrYfLC4ZzdpI2ztxP1I582+49Oc5Mq64VQ=
 github.com/rivo/uniseg v0.4.7/go.mod h1:FN3SvrM+Zdj16jyLfmOkMNblXMcoc8DfTHruCPUcx88=
-github.com/rogpeppe/go-internal v1.13.1 h1:KvO1DLK/DRN07sQ1LQKScxyZJuNnedQ5/wKSR38lUII=
-github.com/rogpeppe/go-internal v1.13.1/go.mod h1:uMEvuHeurkdAXX61udpOXGD/AzZDWNMNyH2VO9fmH0o=
+github.com/rogpeppe/go-internal v1.14.1 h1:UQB4HGPB6osV0SQTLymcB4TgvyWu6ZyliaW0tI/otEQ=
+github.com/rogpeppe/go-internal v1.14.1/go.mod h1:MaRKkUm5W0goXpeCfT7UZI6fk/L7L7so1lCWt35ZSgc=
 github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
 github.com/sagikazarmark/locafero v0.4.0 h1:HApY1R9zGo4DBgr7dqsTH/JJxLTTsOt7u6keLGt6kNQ=
 github.com/sagikazarmark/locafero v0.4.0/go.mod h1:Pe1W6UlPYUk/+wc/6KFhbORCfqzgYEpgQ3O5fPuL3H4=
@@ -108,17 +106,11 @@ go.uber.org/multierr v1.9.0 h1:7fIwc/ZtS0q++VgcfqFDxSBZVv/Xo49/SYnDFupUwlI=
 go.uber.org/multierr v1.9.0/go.mod h1:X2jQV1h+kxSjClGpnseKVIxpmcjrj7MNnI0bnlfKTVQ=
 golang.org/x/exp v0.0.0-20240719175910-8a7402abbf56 h1:2dVuKD2vS7b0QIHQbpyTISPd0LeHDbnYEryqj5Q1ug8=
 golang.org/x/exp v0.0.0-20240719175910-8a7402abbf56/go.mod h1:M4RDyNAINzryxdtnbRXRL/OHtkFuWGRjvuhBJpk2IlY=
-golang.org/x/sync v0.11.0 h1:GGz8+XQP4FvTTrjZPzNKTMFtSXH80RAzG+5ghFPgK9w=
-golang.org/x/sync v0.11.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
 golang.org/x/sync v0.12.0 h1:MHc5BpPuC30uJk597Ri8TV3CNZcTLu6B6z4lJy+g6Jw=
 golang.org/x/sync v0.12.0/go.mod h1:1dzgHSNfp02xaA81J2MS99Qcpr2w7fw1gpm99rleRqA=
 golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/sys v0.30.0 h1:QjkSwP/36a20jFYWkSue1YwXzLmsV5Gfq7Eiy72C1uc=
-golang.org/x/sys v0.30.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
 golang.org/x/sys v0.31.0 h1:ioabZlmFYtWhL+TRYpcnNlLwhyxaM9kWTDEmfnprqik=
 golang.org/x/sys v0.31.0/go.mod h1:BJP2sWEmIv4KK5OTEluFJCKSidICx8ciO85XgH3Ak8k=
-golang.org/x/term v0.25.0 h1:WtHI/ltw4NvSUig5KARz9h521QvRC8RmF/cuYqifU24=
-golang.org/x/term v0.25.0/go.mod h1:RPyXicDX+6vLxogjjRxjgD2TKtmAO6NZBsBRfrOLu7M=
 golang.org/x/term v0.29.0 h1:L6pJp37ocefwRRtYPKSWOWzOtWSxVajvz2ldH/xi3iU=
 golang.org/x/term v0.29.0/go.mod h1:6bl4lRlvVuDgSf3179VpIxBF0o10JUpXWOnI7nErv7s=
 golang.org/x/text v0.18.0 h1:XvMDiNzPAl0jr17s6W9lcaIhGUfUORdGCNsuLmPG224=
@@ -131,7 +123,5 @@ gopkg.in/ini.v1 v1.67.0/go.mod h1:pNLf8WUiyNEtQjuu5G5vTm06TEv9tsIgeAvK8hOrP4k=
 gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
 gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
 gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
-mvdan.cc/sh/v3 v3.10.0 h1:v9z7N1DLZ7owyLM/SXZQkBSXcwr2IGMm2LY2pmhVXj4=
-mvdan.cc/sh/v3 v3.10.0/go.mod h1:z/mSSVyLFGZzqb3ZIKojjyqIx/xbmz/UHdCSv9HmqXY=
 mvdan.cc/sh/v3 v3.11.0 h1:q5h+XMDRfUGUedCqFFsjoFjrhwf2Mvtt1rkMvVz0blw=
 mvdan.cc/sh/v3 v3.11.0/go.mod h1:LRM+1NjoYCzuq/WZ6y44x14YNAI0NK7FLPeQSaFagGg=

go.sum

@@ -1,10 +1,13 @@
 {pkgs, ...}:
 pkgs.mkShellNoCC {
-  env.GOROOT = "${pkgs.go}/share/go";
+  env = {
+    GOROOT = "${pkgs.go_1_24}/share/go";
+    CGO_ENABLED = "0";
+  };
 
   packages =
     (with pkgs; [
-      go
+      go_1_24
       goreleaser
       golangci-lint
       delve