Skip to content

Commit 0a03cfd

Browse files
OsirisTerjeOsirisTerje
authored
Fixtmppath (#1034)
* Fixing * Updated * update runsettings * Updating tests * Ignoring tests that are not isolated * Fixing tests. Removing support for netcore2.1 as it interferes will tests, and is out of MS support
1 parent d0f38dc commit 0a03cfd

24 files changed

+275
-116
lines changed

‎.runsettings

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<RunSettings>
33
<RunConfiguration>
44
<!-- 0 = As many processes as possible, limited by number of cores on machine, 1 = Sequential (1 process), 2-> Given number of processes up to limit by number of cores on machine-->
5-
<MaxCpuCount>0</MaxCpuCount>
5+
<MaxCpuCount>1</MaxCpuCount>
66

77
</RunConfiguration>
88

‎NUnit3TestAdapter.sln

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,11 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "workflows", "workflows", "{
6161
.github\workflows\NUnit3TestAdapter.Cake.CI.yml = .github\workflows\NUnit3TestAdapter.Cake.CI.yml
6262
EndProjectSection
6363
EndProject
64+
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "netcoreapp3.1", "netcoreapp3.1", "{2F940513-5B8F-45A5-A188-7C5D03D1B50D}"
65+
ProjectSection(SolutionItems) = preProject
66+
nuget\netcoreapp3.1\NUnit3TestAdapter.props = nuget\netcoreapp3.1\NUnit3TestAdapter.props
67+
EndProjectSection
68+
EndProject
6469
Global
6570
GlobalSection(SolutionConfigurationPlatforms) = preSolution
6671
Debug|Any CPU = Debug|Any CPU
@@ -100,6 +105,7 @@ Global
100105
{A9584E41-6ECE-44B4-A504-41795A65DA5F} = {DE347D88-F6ED-4031-AFC2-318F63E39BC9}
101106
{062B1763-73C8-4B5A-92DF-C66A36C43CE1} = {7CE30108-5D81-4850-BE6B-C8BCA35D3592}
102107
{7D708804-B2F1-4A31-A9FB-85A0C7433200} = {062B1763-73C8-4B5A-92DF-C66A36C43CE1}
108+
{2F940513-5B8F-45A5-A188-7C5D03D1B50D} = {DE347D88-F6ED-4031-AFC2-318F63E39BC9}
103109
EndGlobalSection
104110
GlobalSection(ExtensibilityGlobals) = postSolution
105111
SolutionGuid = {8EF03474-188E-44A8-8C76-9FBCF9A382EC}

‎build.cake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ var configuration = Argument("configuration", "Release");
1212
// SET PACKAGE VERSION
1313
//////////////////////////////////////////////////////////////////////
1414

15-
var version = "4.3.0";
15+
var version = "4.3.1";
1616
var modifier = "";
1717

1818

@@ -72,7 +72,7 @@ var BIN_DIR = PROJECT_DIR + "bin/" + configuration + "/";
7272

7373
var ADAPTER_PROJECT = SRC_DIR + "NUnitTestAdapter/NUnit.TestAdapter.csproj";
7474

75-
var NETCOREAPP_TFM = "netcoreapp2.1";
75+
var NETCOREAPP_TFM = "netcoreapp3.1";
7676

7777
var ADAPTER_BIN_DIR_NET35 = SRC_DIR + $"NUnitTestAdapter/bin/{configuration}/net35/";
7878
var ADAPTER_BIN_DIR_NETCOREAPP = SRC_DIR + $"NUnitTestAdapter/bin/{configuration}/{NETCOREAPP_TFM}/";

‎nuget/NUnit3TestAdapter.nuspec

Lines changed: 38 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -1,45 +1,44 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<package xmlns="http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd">
3-
<metadata>
4-
<id>NUnit3TestAdapter</id>
5-
<version>$version$</version>
6-
<title>NUnit3 Test Adapter for Visual Studio and DotNet</title>
7-
<authors>Charlie Poole, Terje Sandstrom</authors>
8-
<license type="expression">MIT</license>
9-
<projectUrl>https://docs.nunit.org/articles/vs-test-adapter/Index.html</projectUrl>
10-
<repository type="git" url="https://github.com/nunit/nunit3-vs-adapter"/>
11-
<iconUrl>https://cdn.rawgit.com/nunit/resources/master/images/icon/nunit_256.png</iconUrl>
12-
<requireLicenseAcceptance>false</requireLicenseAcceptance>
13-
<summary>NUnit3 adapter for running tests in Visual Studio and DotNet. Works with NUnit 3.x, use the NUnit 2 adapter for 2.x tests.</summary>
14-
<description>
15-
The NUnit3 TestAdapter for Visual Studio, all versions from 2012 and onwards, and DotNet (incl. .Net core).
3+
<metadata>
4+
<id>NUnit3TestAdapter</id>
5+
<version>$version$</version>
6+
<title>NUnit3 Test Adapter for Visual Studio and DotNet</title>
7+
<authors>Charlie Poole, Terje Sandstrom</authors>
8+
<license type="expression">MIT</license>
9+
<projectUrl>https://docs.nunit.org/articles/vs-test-adapter/Index.html</projectUrl>
10+
<repository type="git" url="https://github.com/nunit/nunit3-vs-adapter"/>
11+
<iconUrl>https://cdn.rawgit.com/nunit/resources/master/images/icon/nunit_256.png</iconUrl>
12+
<requireLicenseAcceptance>false</requireLicenseAcceptance>
13+
<summary>NUnit3 adapter for running tests in Visual Studio and DotNet. Works with NUnit 3.x, use the NUnit 2 adapter for 2.x tests.</summary>
14+
<description>
15+
The NUnit3 TestAdapter for Visual Studio, all versions from 2012 and onwards, and DotNet (incl. .Net core).
1616

17-
Note that this package ONLY contains the adapter, not the NUnit framework.
18-
For VS 2017 and forward, you should add this package to every test project in your solution. (Earlier versions only require a single adapter package per solution.)
19-
</description>
20-
<releaseNotes>See https://docs.nunit.org/articles/vs-test-adapter/Adapter-Release-Notes.html </releaseNotes>
21-
<copyright>Copyright (c) 2011-2021 Charlie Poole, 2014-2022 Terje Sandstrom</copyright>
22-
<language>en-US</language>
23-
<tags>test visualstudio testadapter nunit nunit3 dotnet</tags>
17+
Note that this package ONLY contains the adapter, not the NUnit framework.
18+
For VS 2017 and forward, you should add this package to every test project in your solution. (Earlier versions only require a single adapter package per solution.)
19+
</description>
20+
<releaseNotes>See https://docs.nunit.org/articles/vs-test-adapter/Adapter-Release-Notes.html </releaseNotes>
21+
<copyright>Copyright (c) 2011-2021 Charlie Poole, 2014-2022 Terje Sandstrom</copyright>
22+
<language>en-US</language>
23+
<tags>test visualstudio testadapter nunit nunit3 dotnet</tags>
2424

25-
<developmentDependency>false</developmentDependency>
26-
</metadata>
27-
<files>
28-
<file src="build\net35\NUnit3.TestAdapter.dll" target="build\net35\NUnit3.TestAdapter.dll" />
29-
<file src="build\net35\NUnit3.TestAdapter.pdb" target="build\net35\NUnit3.TestAdapter.pdb" />
30-
<file src="build\net35\nunit.engine.dll" target="build\net35\nunit.engine.dll" />
31-
<file src="build\net35\nunit.engine.api.dll" target="build\net35\nunit.engine.api.dll" />
32-
<file src="build\net35\nunit.engine.core.dll" target="build\net35\nunit.engine.core.dll" />
33-
<file src="build\net35\testcentric.engine.metadata.dll" target="build\net35\testcentric.engine.metadata.dll"/>
34-
<file src="build\net35\NUnit3TestAdapter.props" target="build\net35\NUnit3TestAdapter.props" />
25+
<developmentDependency>false</developmentDependency>
26+
</metadata>
27+
<files>
28+
<file src="build\net35\NUnit3.TestAdapter.dll" target="build\net35\NUnit3.TestAdapter.dll" />
29+
<file src="build\net35\NUnit3.TestAdapter.pdb" target="build\net35\NUnit3.TestAdapter.pdb" />
30+
<file src="build\net35\nunit.engine.dll" target="build\net35\nunit.engine.dll" />
31+
<file src="build\net35\nunit.engine.api.dll" target="build\net35\nunit.engine.api.dll" />
32+
<file src="build\net35\nunit.engine.core.dll" target="build\net35\nunit.engine.core.dll" />
33+
<file src="build\net35\testcentric.engine.metadata.dll" target="build\net35\testcentric.engine.metadata.dll"/>
34+
<file src="build\net35\NUnit3TestAdapter.props" target="build\net35\NUnit3TestAdapter.props" />
3535

36-
<file src="build\netcoreapp2.1\NUnit3.TestAdapter.dll" target="build\netcoreapp2.1\NUnit3.TestAdapter.dll" />
37-
<file src="build\netcoreapp2.1\NUnit3.TestAdapter.pdb" target="build\netcoreapp2.1\NUnit3.TestAdapter.pdb" />
38-
<file src="build\netcoreapp2.1\nunit.engine.dll" target="build\netcoreapp2.1\nunit.engine.dll" />
39-
<file src="build\netcoreapp2.1\nunit.engine.api.dll" target="build\netcoreapp2.1\nunit.engine.api.dll" />
40-
<file src="build\netcoreapp2.1\nunit.engine.core.dll" target="build\netcoreapp2.1\nunit.engine.core.dll" />
41-
<file src="build\netcoreapp2.1\testcentric.engine.metadata.dll" target="build\netcoreapp2.1\testcentric.engine.metadata.dll"/>
42-
<file src="build\netcoreapp2.1\NUnit3TestAdapter.props" target="build\netcoreapp2.1\NUnit3TestAdapter.props" />
43-
44-
</files>
36+
<file src="build\netcoreapp3.1\NUnit3.TestAdapter.dll" target="build\netcoreapp3.1\NUnit3.TestAdapter.dll" />
37+
<file src="build\netcoreapp3.1\NUnit3.TestAdapter.pdb" target="build\netcoreapp3.1\NUnit3.TestAdapter.pdb" />
38+
<file src="build\netcoreapp3.1\nunit.engine.dll" target="build\netcoreapp3.1\nunit.engine.dll" />
39+
<file src="build\netcoreapp3.1\nunit.engine.api.dll" target="build\netcoreapp3.1\nunit.engine.api.dll" />
40+
<file src="build\netcoreapp3.1\nunit.engine.core.dll" target="build\netcoreapp3.1\nunit.engine.core.dll" />
41+
<file src="build\netcoreapp3.1\testcentric.engine.metadata.dll" target="build\netcoreapp3.1\testcentric.engine.metadata.dll"/>
42+
<file src="build\netcoreapp3.1\NUnit3TestAdapter.props" target="build\netcoreapp3.1\NUnit3TestAdapter.props" />
43+
</files>
4544
</package>

‎nuget/netcoreapp3.1/NUnit3TestAdapter.props

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<Project ToolsVersion="12.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
3+
<ItemGroup>
4+
<None Include="$(MSBuildThisFileDirectory)NUnit3.TestAdapter.dll">
5+
<Link>NUnit3.TestAdapter.dll</Link>
6+
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
7+
<Visible>False</Visible>
8+
</None>
9+
<None Include="$(MSBuildThisFileDirectory)NUnit3.TestAdapter.pdb" Condition="Exists('$(MSBuildThisFileDirectory)NUnit3.TestAdapter.pdb')">
10+
<Link>NUnit3.TestAdapter.pdb</Link>
11+
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
12+
<Visible>False</Visible>
13+
</None>
14+
<None Include="$(MSBuildThisFileDirectory)nunit.engine.dll">
15+
<Link>nunit.engine.dll</Link>
16+
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
17+
<Visible>False</Visible>
18+
</None>
19+
<None Include="$(MSBuildThisFileDirectory)nunit.engine.api.dll">
20+
<Link>nunit.engine.api.dll</Link>
21+
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
22+
<Visible>False</Visible>
23+
</None>
24+
<None Include="$(MSBuildThisFileDirectory)nunit.engine.core.dll">
25+
<Link>nunit.engine.core.dll</Link>
26+
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
27+
<Visible>False</Visible>
28+
</None>
29+
<None Include="$(MSBuildThisFileDirectory)testcentric.engine.metadata.dll">
30+
<Link>testcentric.engine.metadata.dll</Link>
31+
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
32+
<Visible>False</Visible>
33+
</None>
34+
</ItemGroup>
35+
</Project>

‎src/NUnit.TestAdapter.Tests.Acceptance/AcceptanceTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@ public abstract class AcceptanceTests
3232
public static IEnumerable<string> TargetFrameworks => new[]
3333
{
3434
LowestNetfxTarget,
35-
Frameworks.NetCoreApp21
35+
Frameworks.NetCoreApp31
3636
};
3737

3838
public static IEnumerable<string> DotNetCliTargetFrameworks => new[]
3939
{
40-
Frameworks.NetCoreApp21,
40+
// Frameworks.NetCoreApp21, // Doesnt seem to be supported by VS 2022 anymore
4141
Frameworks.NetCoreApp31,
4242
Frameworks.Net50,
4343
Frameworks.Net60,

‎src/NUnit.TestAdapter.Tests.Acceptance/NUnit.TestAdapter.Tests.Acceptance.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<ItemGroup>
1313
<PackageReference Include="nunit" Version="3.13.3" />
1414
<PackageReference Include="NUnit3TestAdapter" Version="4.3.0" />
15-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.2" />
15+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.0" />
1616
<PackageReference Include="NUnit.Analyzers" Version="3.5.0" />
1717
</ItemGroup>
1818

‎src/NUnit.TestAdapter.Tests.Acceptance/TestSourceWithCustomNames.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,9 @@ public class Case
8383

8484
[Test, Platform("Win")]
8585
[TestCase("net48")] // test code requires ValueTuple support, so can't got to net35
86-
[TestCase("netcoreapp2.1")]
86+
[TestCase("netcoreapp3.1")]
8787
[TestCase("net5.0")]
88+
[TestCase("net6.0")]
8889
public static void Single_target_csproj(string targetFramework)
8990
{
9091
var workspace = CreateWorkspace()

‎src/NUnit3AdapterExternalTests/NUnit3AdapterExternalTests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<PropertyGroup>
44
<AssemblyName>NUnit.VisualStudio.TestAdapter.ExternalTests</AssemblyName>
55
<RootNamespace>NUnit.VisualStudio.TestAdapter.Tests</RootNamespace>
6-
<TargetFrameworks>net45;netcoreapp2.1</TargetFrameworks>
6+
<TargetFrameworks>net45;netcoreapp3.1</TargetFrameworks>
77
</PropertyGroup>
88

99
<ItemGroup>

‎src/NUnitTestAdapter/AdapterSettings.cs

Lines changed: 65 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
using Microsoft.VisualStudio.TestPlatform.ObjectModel;
3030
using Microsoft.VisualStudio.TestPlatform.ObjectModel.Adapter;
3131

32+
using NUnit.Engine;
33+
3234
namespace NUnit.VisualStudio.TestAdapter
3335
{
3436
public interface IAdapterSettings
@@ -40,7 +42,7 @@ public interface IAdapterSettings
4042
string TestAdapterPaths { get; }
4143
bool CollectSourceInformation { get; }
4244
IDictionary<string, string> TestProperties { get; }
43-
string InternalTraceLevel { get; }
45+
InternalTraceLevel InternalTraceLevelEnum { get; }
4446
string WorkDirectory { get; }
4547
string Where { get; }
4648
int DefaultTimeout { get; }
@@ -115,7 +117,7 @@ public interface IAdapterSettings
115117
bool IncludeStackTraceForSuites { get; }
116118

117119

118-
void Load(IDiscoveryContext context);
120+
void Load(IDiscoveryContext context, TestLogger testLogger = null);
119121
void Load(string settingsXml);
120122
void SaveRandomSeed(string dirname);
121123
void RestoreRandomSeed(string dirname);
@@ -132,6 +134,7 @@ public interface IAdapterSettings
132134
ExplicitModeEnum ExplicitMode { get; }
133135
bool SkipExecutionWhenNoTests { get; }
134136
string TestOutputFolder { get; }
137+
string SetTestOutputFolder(string workDirectory);
135138
}
136139

137140
public enum VsTestCategoryType
@@ -210,7 +213,11 @@ public AdapterSettings(ITestLogger logger)
210213
#region Properties - NUnit Specific
211214

212215
public string InternalTraceLevel { get; private set; }
216+
public InternalTraceLevel InternalTraceLevelEnum { get; private set; }
213217

218+
/// <summary>
219+
/// Is null if not set in runsettings.
220+
/// </summary>
214221
public string WorkDirectory { get; private set; }
215222
public string Where { get; private set; }
216223
public string TestOutputXml { get; private set; }
@@ -303,8 +310,14 @@ public AdapterSettings(ITestLogger logger)
303310

304311
#region Public Methods
305312

306-
public void Load(IDiscoveryContext context)
313+
/// <summary>
314+
/// Initialized by the Load method.
315+
/// </summary>
316+
private TestLogger testLog;
317+
318+
public void Load(IDiscoveryContext context, TestLogger testLogger)
307319
{
320+
testLog = testLogger;
308321
if (context == null)
309322
throw new ArgumentNullException(nameof(context), "Load called with null context");
310323

@@ -338,12 +351,9 @@ public void Load(string settingsXml)
338351
UseVsKeepEngineRunning = GetInnerTextAsBool(nunitNode, nameof(UseVsKeepEngineRunning), false);
339352
BasePath = GetInnerTextWithLog(nunitNode, nameof(BasePath));
340353
PrivateBinPath = GetInnerTextWithLog(nunitNode, nameof(PrivateBinPath));
341-
TestOutputXml = GetInnerTextWithLog(nunitNode, nameof(TestOutputXml));
342-
OutputXmlFolderMode = MapEnum(GetInnerText(nunitNode, nameof(OutputXmlFolderMode), Verbosity > 0), OutputXmlFolderMode.RelativeToWorkFolder);
354+
ParseOutputXml(nunitNode);
343355
NewOutputXmlFileForEachRun = GetInnerTextAsBool(nunitNode, nameof(NewOutputXmlFileForEachRun), false);
344356

345-
SetTestOutputFolder();
346-
347357
RandomSeed = GetInnerTextAsNullableInt(nunitNode, nameof(RandomSeed));
348358
RandomSeedSpecified = RandomSeed.HasValue;
349359
if (!RandomSeedSpecified)
@@ -418,24 +428,44 @@ public void Load(string settingsXml)
418428
UpdateNumberOfTestWorkers();
419429
}
420430

421-
private void SetTestOutputFolder()
431+
private void ParseOutputXml(XmlNode nunitNode)
422432
{
423-
if (!UseTestOutputXml)
433+
TestOutputXml = GetInnerTextWithLog(nunitNode, nameof(TestOutputXml));
434+
if (Path.IsPathRooted(TestOutputXml))
435+
{
436+
OutputXmlFolderMode = OutputXmlFolderMode.AsSpecified;
424437
return;
438+
}
439+
var outputMode = GetInnerText(nunitNode, nameof(OutputXmlFolderMode), Verbosity > 0);
440+
441+
if (string.IsNullOrEmpty(WorkDirectory) && string.IsNullOrEmpty(outputMode))
442+
{
443+
OutputXmlFolderMode = string.IsNullOrEmpty(TestOutputXml) ? OutputXmlFolderMode.UseResultDirectory : OutputXmlFolderMode.RelativeToResultDirectory;
444+
}
445+
446+
OutputXmlFolderMode = MapEnum(outputMode, OutputXmlFolderMode.RelativeToWorkFolder);
447+
}
448+
449+
public string SetTestOutputFolder(string workDirectory)
450+
{
451+
if (!UseTestOutputXml)
452+
return "";
425453
switch (OutputXmlFolderMode)
426454
{
427455
case OutputXmlFolderMode.UseResultDirectory:
428456
TestOutputFolder = ResultsDirectory;
429-
return;
457+
return TestOutputFolder;
430458
case OutputXmlFolderMode.RelativeToResultDirectory:
431459
TestOutputFolder = Path.Combine(ResultsDirectory, TestOutputXml);
432-
return;
460+
return TestOutputFolder;
433461
case OutputXmlFolderMode.RelativeToWorkFolder:
434-
TestOutputFolder = Path.Combine(WorkDirectory, TestOutputXml);
435-
return;
462+
TestOutputFolder = Path.Combine(workDirectory, TestOutputXml);
463+
return TestOutputFolder;
436464
case OutputXmlFolderMode.AsSpecified:
465+
TestOutputFolder = TestOutputXml;
466+
return TestOutputFolder;
437467
default:
438-
return;
468+
return "";
439469
}
440470
}
441471

@@ -445,13 +475,32 @@ private void ExtractNUnitDiagnosticSettings(XmlNode nunitNode)
445475
DumpXmlTestResults = GetInnerTextAsBool(nunitNode, nameof(DumpXmlTestResults), false);
446476
DumpVsInput = GetInnerTextAsBool(nunitNode, nameof(DumpVsInput), false);
447477
FreakMode = GetInnerTextAsBool(nunitNode, nameof(FreakMode), false);
448-
InternalTraceLevel = GetInnerTextWithLog(nunitNode, nameof(InternalTraceLevel), "Off", "Error", "Warning",
449-
"Info", "Verbose", "Debug");
478+
InternalTraceLevel = GetInnerTextWithLog(nunitNode, nameof(InternalTraceLevel), "Off", "Error", "Warning", "Info", "Verbose", "Debug");
479+
InternalTraceLevelEnum = ParseInternalTraceLevel(InternalTraceLevel);
450480
Debug = GetInnerTextAsBool(nunitNode, nameof(Debug), false);
451481
DebugExecution = Debug || GetInnerTextAsBool(nunitNode, nameof(DebugExecution), false);
452482
DebugDiscovery = Debug || GetInnerTextAsBool(nunitNode, nameof(DebugDiscovery), false);
453483
}
454484

485+
private InternalTraceLevel ParseInternalTraceLevel(string s)
486+
{
487+
if (s == null)
488+
{
489+
return Engine.InternalTraceLevel.Off;
490+
}
491+
492+
try
493+
{
494+
var internalTrace = (InternalTraceLevel)Enum.Parse(typeof(InternalTraceLevel), s);
495+
return internalTrace;
496+
}
497+
catch
498+
{
499+
testLog.Warning($"InternalTraceLevel is non-valid: {s}, see https://docs.nunit.org/articles/vs-test-adapter/Tips-And-Tricks.html");
500+
return Engine.InternalTraceLevel.Off;
501+
}
502+
}
503+
455504
private void UpdateTestProperties(XmlDocument doc)
456505
{
457506
TestProperties = new Dictionary<string, string>();

‎src/NUnitTestAdapter/NUnit.TestAdapter.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
<AssemblyName>NUnit3.TestAdapter</AssemblyName>
55
<!--<AssemblyName>NUnit3.TestAdapterDebug</AssemblyName>-->
66
<RootNamespace>NUnit.VisualStudio.TestAdapter</RootNamespace>
7-
<!--<TargetFramework>netcoreapp2.1</TargetFramework>-->
7+
<!--<TargetFramework>netcoreapp3.1</TargetFramework>-->
88
<!-- For testing and debugging-->
9-
<TargetFrameworks>net35;netcoreapp2.1</TargetFrameworks>
9+
<TargetFrameworks>net35;netcoreapp3.1</TargetFrameworks>
1010
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
1111
<SourceLinkOriginUrl>https://github.com/nunit/nunit3-vs-adapter</SourceLinkOriginUrl>
1212
<SourceLinkCreate>true</SourceLinkCreate>

0 commit comments

Comments
 (0)