(#18) Migrating window tests to playwright, WIP

Author: s1hofmann

src/macos/window_manager.mm

@@ -200,11 +200,7 @@ bool focusWindow(const WindowHandle windowHandle) {
 }
 
 /**
- * Resizes and repositions the window provided via its handle to the specified rectangle.
- *
- * This function retrieves window information using the provided window handle, then uses 
- * macOS Accessibility APIs to resize and reposition the window to fit within the provided 
- * rectangle dimensions and location.
+ * Resizes the window provided via its handle to the specified width/height.
  *
  * @param windowHandle Handle to the window that needs to be resized.
  * @param newSize The width/height to which the window should be resized.
@@ -255,11 +251,7 @@ bool resizeWindow(const WindowHandle windowHandle, const MMSize newSize) {
 }
 
 /**
- * Resizes and repositions the window provided via its handle to the specified rectangle.
- *
- * This function retrieves window information using the provided window handle, then uses
- * macOS Accessibility APIs to resize and reposition the window to fit within the provided
- * rectangle dimensions and location.
+ * Moves the window provided via its handle to the specified point.
  *
  * @param windowHandle Handle to the window that needs to be resized.
  * @param newOrigin The x/y coordinates to which the window should be repositioned.
@@ -280,8 +272,7 @@ bool moveWindow(const WindowHandle windowHandle, const MMPoint newOrigin) {
     AXUIElementRef app = AXUIElementCreateApplication(pid);
     AXUIElementRef window;
 
-    AXError error = AXUIElementCopyAttributeValue(app, kAXFocusedWindowAttribute,
-                                                  (CFTypeRef *) &window);
+    AXError error = AXUIElementCopyAttributeValue(app, kAXFocusedWindowAttribute, (CFTypeRef *) &window);
 
     // If no error occurred, proceed with the resize and reposition operations
     if (error == kAXErrorSuccess) {
@@ -299,12 +290,12 @@ bool moveWindow(const WindowHandle windowHandle, const MMPoint newOrigin) {
         CFRelease(app);
 
         // Return true to indicate successful resize
-        return true;
+        return YES;
     } else {
         // NSLog(@"Could not resize window with window handle %lld", windowHandle);
         CFRelease(app);
         return false;
     }
 
-    return true;
+    return YES;
 }

src/main.cc

@@ -7,6 +7,7 @@
 #include "screen.h"
 #include "screengrab.h"
 #include "window_manager.h"
+#include <iostream>
 
 int mouseDelay = 10;
 int keyboardDelay = 10;
@@ -688,14 +689,15 @@ Napi::Boolean _moveWindow(const Napi::CallbackInfo& info) {
     }
 
     WindowHandle windowHandle = info[0].As<Napi::Number>().Int64Value();
-    auto rectObj = info[1].As<Napi::Object>();
 
+    auto rectObj = info[1].As<Napi::Object>();
     if (!rectObj.Has("x") || !rectObj.Has("y")) {
         throw Napi::TypeError::New(env, "Invalid second parameter. Expected object of shape {x: number, y: number}");
     }
 
     auto x = rectObj.Get("x").As<Napi::Number>().Int64Value();
     auto y = rectObj.Get("y").As<Napi::Number>().Int64Value();
+    std::cout << "moving to " << x << ", " << y << std::endl;
 
     auto newOrigin = MMPointMake(x, y);