Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows display scaling is applied in wrong direction #92

Closed
s1hofmann opened this issue Dec 28, 2021 · 1 comment · Fixed by #93
Closed

Windows display scaling is applied in wrong direction #92

s1hofmann opened this issue Dec 28, 2021 · 1 comment · Fixed by #93
Labels
bug Something isn't working

Comments

@s1hofmann
Copy link
Member

Version
2.1.3

Short overview
The Windows display scaling correction is applied in the wrong direction

Detailed error description
Instead of rescaling the actual image size to the unscaled size, it currently reduces the actual image size even further, leading to bugs down the line
@s1hofmann s1hofmann added the bug Something isn't working label Dec 28, 2021
s1hofmann added a commit that referenced this issue Dec 28, 2021
@s1hofmann
(#92) Fix application of scale factor when calculating actual image s…
8580f27 
…izes for screen grabs
s1hofmann added a commit that referenced this issue Dec 28, 2021
@s1hofmann
(#92) Adjusted test to new macOS env by increasing default menu bar h…
9efd027 
…eight to 25 px
s1hofmann added a commit that referenced this issue Dec 28, 2021
@s1hofmann
(#92) Fix application of scale factor when calculating actual image s… (
9aaaa1c 
#93)

* (#92) Fix application of scale factor when calculating actual image sizes for screen grabs

* (#92) Adjusted test to new macOS env by increasing default menu bar height to 25 px
@s1hofmann s1hofmann linked a pull request Dec 28, 2021 that will close this issue
(#92) Fix application of scale factor when calculating actual image s… #93
Merged
@s1hofmann
Copy link
Member Author

Closed by #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(#92) Fix application of scale factor when calculating actual image s… nut-tree/libnut-core
1 participant
@s1hofmann