Add arch flag for universal mac builds #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, let me know if there's anything blocking this <3 |
|
Hi @momakes2 👋 I’ll have to read up on a few things before merging this PR. I’ll let you know if I have any questions |
s1hofmann
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I investigated a bit and looks like the only way to make it work here is by the CLI flag.
I tried adding it to CMakeLists.txt but it never worked despite different suggestions online (seems to be a known issue).
This flag is ignored on non-OSX environments and targets so it's safe in that regard.
Let me know if this is okay.
Fixes #49