(#68) Moved scaling of search regions into separate file

Author: s1hofmann

Diff for: lib/provider/opencv/determine-searchregion.function.spec.ts

@@ -0,0 +1,60 @@
+import { mockPartial } from "sneer";
+import { Image } from "../../image.class";
+import { MatchRequest } from "../../match-request.class";
+import { Region } from "../../region.class";
+import { determineScaledSearchRegion } from "./determine-searchregion.function";
+
+describe("determineSearchRegion", () => {
+  it("should return a search region adopted to pixel density", () => {
+    // GIVEN
+    const imageMock = mockPartial<Image>({
+      pixelDensity: {
+        scaleX: 1.5,
+        scaleY: 2.0
+      }
+    });
+    const needlePath = "/path/to/needle";
+    const inputSearchRegion = new Region(0, 0, 100, 100);
+    const expectedSearchRegion = new Region(0, 0, 150, 200);
+
+    const matchRequest = new MatchRequest(
+      imageMock,
+      needlePath,
+      inputSearchRegion,
+      0.99
+    );
+
+    // WHEN
+    const result = determineScaledSearchRegion(matchRequest);
+
+    // THEN
+    expect(result).toEqual(expectedSearchRegion);
+  });
+
+  it.each([[0, 1], [1, 0]])("should not adjust searchregion for factor 0: scaleX: %i scaleY: %i",
+    (scaleX: number, scaleY: number) => {
+      // GIVEN
+      const imageMock = mockPartial<Image>({
+        pixelDensity: {
+          scaleX,
+          scaleY
+        }
+      });
+      const needlePath = "/path/to/needle";
+      const inputSearchRegion = new Region(0, 0, 100, 100);
+      const expectedSearchRegion = new Region(0, 0, 100, 100);
+
+      const matchRequest = new MatchRequest(
+        imageMock,
+        needlePath,
+        inputSearchRegion,
+        0.99
+      );
+
+      // WHEN
+      const result = determineScaledSearchRegion(matchRequest);
+
+      // THEN
+      expect(result).toEqual(expectedSearchRegion);
+    });
+});

Diff for: lib/provider/opencv/determine-searchregion.function.ts

@@ -0,0 +1,11 @@
+import { MatchRequest } from "../../match-request.class";
+import { Region } from "../../region.class";
+
+export const determineScaledSearchRegion = (matchRequest: MatchRequest): Region => {
+  const searchRegion = matchRequest.searchRegion;
+  const scaleX = matchRequest.haystack.pixelDensity.scaleX || 1.0;
+  const scaleY = matchRequest.haystack.pixelDensity.scaleY || 1.0;
+  searchRegion.width *= scaleX;
+  searchRegion.height *= scaleY;
+  return searchRegion;
+};

Diff for: package-lock.json

@@ -62,6 +62,7 @@
     "@types/clipboardy": "^1.1.0",
     "@types/jest": "^24.0.9",
     "jest": "^24.7.1",
+    "sneer": "^1.0.1",
     "ts-jest": "^24.0.2",
     "tslint": "^5.16.0",
     "typescript": "^3.4.3",