feat: Use kustomize instead of Helm for deployment (#72)

Author: jimmidyson

.github/workflows/checks.yml

@@ -134,70 +134,3 @@ jobs:
         run: devbox run -- make pre-commit
         env:
           SKIP: no-commit-to-branch,golangci-lint,actionlint-system
-
-  lint-test-helm:
-    runs-on: ubuntu-22.04
-    env:
-      KIND_CLUSTER_NAME: chart-testing
-      KIND_KUBECONFIG: ct-kind-kubeconfig
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-
-      - name: Install devbox
-        uses: jetify-com/[email protected]
-        with:
-          enable-cache: true
-
-      - name: Run chart-testing (list-changed)
-        id: list-changed
-        run: |
-          changed="$(devbox run -- \
-            ct list-changed --config charts/ct-config.yaml \
-          )"
-          if [[ -n "$changed" ]]; then
-            echo "changed=true" >> "$GITHUB_OUTPUT"
-          fi
-
-      - if: steps.list-changed.outputs.changed == 'true'
-        name: Run chart-testing (lint)
-        run: |
-          devbox run -- \
-            ct lint --config charts/ct-config.yaml
-
-      - if: steps.list-changed.outputs.changed == 'true'
-        name: Create kind cluster
-        run: devbox run -- make kind.create
-
-      - if: steps.list-changed.outputs.changed == 'true'
-        name: Build Docker images
-        run: devbox run -- make release-snapshot
-
-      - if: steps.list-changed.outputs.changed == 'true'
-        name: Sideload docker image
-        run: |
-          devbox run -- \
-            kind load docker-image \
-              --name "${KIND_CLUSTER_NAME}" \
-              "ko.local/${{ github.event.repository.name }}:$(devbox run -- gojq -r '.version+"-"+.runtime.goarch' dist/metadata.json)"
-
-      - if: steps.list-changed.outputs.changed == 'true'
-        name: Setup Cluster API and cert-manager
-        run: devbox run -- make clusterctl.init
-
-      - if: steps.list-changed.outputs.changed == 'true'
-        name: Run chart-testing (install)
-        run: |
-          devbox run -- \
-            ct install \
-              --config charts/ct-config.yaml \
-              --helm-extra-set-args "--set-string image.repository=ko.local/${{ github.event.repository.name }} --set-string image.tag=$(devbox run -- gojq -r '.version+"-"+.runtime.goarch' dist/metadata.json)"
-        env:
-          KUBECONFIG: ${{ env.KIND_KUBECONFIG }}
-
-      - if: steps.list-changed.outputs.changed == 'true' && always()
-        name: Delete chart-testing KinD cluster
-        run: |
-          devbox run -- make kind.delete

.github/workflows/github-pages.yml

@@ -51,22 +51,6 @@ jobs:
         run: if [[ -f package-lock.json || -f npm-shrinkwrap.json ]]; then npm ci; fi
         working-directory: docs
 
-      - name: Update Helm index
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          mapfile -t releases < <( devbox run -- make list-releases )
-          for release in "${releases[@]}"; do
-            if devbox run -- gh release download "${release}" \
-                --pattern '${{ github.event.repository.name }}-*.tgz' \
-                --dir docs/static/helm 2>/dev/null; then
-              devbox run -- helm repo index docs/static/helm \
-                --url "https://github.com/${{ github.repository }}/releases/download/${release}" \
-                --merge docs/static/helm/index.yaml
-              rm -f docs/static/helm/*.tgz
-            fi
-          done
-
       - name: Build with Hugo
         env:
           # For maximum backward compatibility with Hugo modules

.github/workflows/release-tag.yml

@@ -54,16 +54,6 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: Package Helm chart and attach to release
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          devbox run -- helm package ./charts/${{ github.event.repository.name }} \
-                          --destination . \
-                          --version ${{ github.ref_name }} \
-                          --app-version ${{ github.ref_name }}
-          devbox run -- gh release upload ${{ github.ref_name }} ${{ github.event.repository.name }}-*.tgz
-
       - name: Build GitHub pages
         uses: benc-uk/workflow-dispatch@v1
         with:

.goreleaser.yml

@@ -40,20 +40,8 @@ archives:
 
 before:
   hooks:
-    - |
-      sh -ec 'cat <<EOF > ipam-components.yaml
-      apiVersion: v1
-      kind: Namespace
-      metadata:
-        name: caipamx-system
-      $(helm template {{ .ProjectName }} ./charts/{{ .ProjectName }} \
-        --namespace caipamx-system \
-        --include-crds \
-        --set-string image.tag=v{{ trimprefix .Version "v" }}{{ if .IsSnapshot }}-{{ .Runtime.Goarch }} \
-        --set-string image.repository=ko.local/{{ .ProjectName }}{{ end }} \
-      )
-      EOF'
-    - sed -i -e 's/\${/$${/g' -e 's/v0.0.0-dev/v{{ trimprefix .Version "v" }}/g' ipam-components.yaml
+    - kustomize build ./config/default >ipam-components.yaml
+    - sed -i -e 's/v0.0.0-dev/v{{ trimprefix .Version "v" }}/g' ipam-components.yaml
     - |
       sh -ec 'gojq --yaml-input --yaml-output \
         ".releaseSeries |= (. + [{contract: \"v1beta1\", major: {{ .Major }}, minor: {{ .Minor }}}] | unique)" \
@@ -82,19 +70,6 @@ builds:
       - amd64
       - arm64
     mod_timestamp: '{{ .CommitTimestamp }}'
-    hooks:
-      post:
-        - |
-          sh -ec 'if [ {{ .IsSnapshot }} == true ] && [ {{ .Runtime.Goarch }} == {{ .Arch }} ]; then
-            env SOURCE_DATE_EPOCH=$(date +%s) \
-                KO_DATA_DATE_EPOCH=$(date +%s) \
-                KO_DOCKER_REPO=ko.local/{{ .ProjectName }} \
-                ko build \
-                  --bare \
-                  --platform linux/{{ .Arch }} \
-                  -t v{{ trimprefix .Version "v" }}-{{ .Arch }} \
-                  ./cmd/controller
-          fi'
   - id: cli
     dir: ./cmd/caipamx
     binary: caipamx

.pre-commit-config.yaml

@@ -4,23 +4,12 @@
 repos:
 - repo: local
   hooks:
-  - id: schema-chart
-    name: schema-chart
-    entry: make schema-chart
-    language: system
-    files: "^charts/[^/]+/values.yaml$"
   - id: golangci-lint
     name: golangci-lint
     entry: make go-generate lint
     language: system
     files: "(.*\\.go|go.mod|go.sum|go.mk)$"
     pass_filenames: false
-  - id: chart-docs
-    name: chart-docs
-    entry: make chart-docs
-    language: system
-    files: "^charts/"
-    pass_filenames: false
   - id: hugo-mod-tidy
     name: hugo-mod-tidy
     entry: bash -c "cd docs && hugo mod tidy"
@@ -46,7 +35,6 @@ repos:
   - id: check-yaml
     args: ["-m", "--unsafe"]
     stages: [pre-commit]
-    exclude: ^charts/.+/templates/
   - id: mixed-line-ending
     args: ["-f", "lf"]
     exclude: \.bat$
@@ -65,7 +53,6 @@ repos:
     stages: [pre-commit]
   - id: end-of-file-fixer
     stages: [pre-commit]
-    exclude: ^charts/[^/]+/README.md$
 - repo: https://github.com/rhysd/actionlint
   rev: v1.7.7
   hooks:
@@ -98,7 +85,7 @@ repos:
   hooks:
   - id: markdownlint
     stages: [pre-commit]
-    exclude: ^(CHANGELOG.md|charts/[^/]+/README.md|.github/pull_request_template.md)$
+    exclude: ^(CHANGELOG.md|.github/pull_request_template.md)$
 - repo: https://github.com/Lucas-C/pre-commit-hooks
   rev: v1.5.5
   hooks:
@@ -116,7 +103,6 @@ repos:
     name: License headers - YAML and Makefiles
     stages: [pre-commit]
     files: (^Makefile|\.(ya?ml|mk))$
-    exclude: ^docs/static/helm/index\.yaml$
     args:
       - --license-filepath
       - hack/license-header.txt

README.md

@@ -24,7 +24,7 @@ make dev.run-on-kind
 eval $(make kind.kubeconfig)
 ```
 
-Pro-tip: to redeploy without rebuilding the binaries, images, etc (useful if you have only changed the Helm chart for
+Pro-tip: to redeploy without rebuilding the binaries, images, etc (useful if you have only changed the deployment
 example), run:
 
 ```shell

api/v1alpha1/v1alpha1_suite_test.go

@@ -4,7 +4,7 @@
 package v1alpha1_test
 
 import (
-	"path/filepath"
+	"os/exec"
 	"testing"
 
 	. "github.com/onsi/ginkgo/v2"
@@ -33,10 +33,14 @@ var _ = BeforeSuite(func() {
 	logf.SetLogger(zap.New(zap.WriteTo(GinkgoWriter), zap.UseDevMode(true)))
 
 	By("bootstrapping test environment")
+	crdTempDir := GinkgoT().TempDir()
+
+	Expect(
+		exec.Command("kustomize", "build", "../../config/crd", "-o", crdTempDir).Run(),
+	).To(Succeed())
+
 	testEnv = &envtest.Environment{
-		CRDDirectoryPaths: []string{
-			filepath.Join("..", "..", "charts", "cluster-api-ipam-provider-nutanix", "crds"),
-		},
+		CRDDirectoryPaths:     []string{crdTempDir},
 		ErrorIfCRDPathMissing: true,
 	}