Skip to content

feat: add router name property for framework7 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from Mar 20, 2019
Merged

feat: add router name property for framework7 #58

merged 4 commits into from Mar 20, 2019

Conversation

alterhu2020
Copy link
Contributor

please have a review this change.

@alterhu2020 alterhu2020 mentioned this pull request Mar 20, 2019
Closed
@pi0
Copy link
Member

pi0 commented Mar 20, 2019

@alterhu2020 Hi. Thanks for both improvements. I think routes.js has been accidentally removed in the last commit. Can you please revert it?

@alterhu2020
Copy link
Contributor Author

alterhu2020 commented Mar 20, 2019 •
edited
Loading

yes, I had reverted it now . Also fixed the windows path issue here ,please have a review . @pi0

@pi0 pi0 merged commit ac74dd5 into nuxt-community:master Mar 20, 2019
@alterhu2020 alterhu2020 mentioned this pull request Mar 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alterhu2020 @pi0 @walterhu2020