feat: add no-env-in-mounted

Author: clarkdo

docs/rules/no-env-in-mounted.md

@@ -0,0 +1,48 @@
+# nuxt/no-env-in-mounted
+
+> disallow `process.server/process.client` in `mounted/beforeMount`
+
+- :gear: This rule is included in `"plugin:nuxt/base"`.
+
+## Rule Details
+
+This rule is for preventing using `process.server/process.client` in `mounted/beforeMount` since they're only executed in client side.
+
+Examples of **incorrect** code for this rule:
+
+```js
+
+export default {
+  mounted() {
+    const foo = 'bar'
+  },
+  beforeMount() {
+    const foo = 'bar'
+  }
+}
+
+```
+
+Examples of **correct** code for this rule:
+
+```js
+
+export default {
+  mounted() {
+    if(process.server) {
+      const foo = 'bar'
+    }
+  },
+  beforeMount() {
+    if(process.client) {
+      const foo = 'bar'
+    }
+  }
+}
+
+```
+
+## :mag: Implementation
+
+- [Rule source](https://github.com/nuxt/eslint-plugin-nuxt/blob/master/lib/rules/no-env-in-mounted.js)
+- [Test source](https://github.com/nuxt/eslint-plugin-nuxt/blob/master/lib/rules/__test__/no-env-in-mounted.test.js)

lib/configs/base.js

@@ -16,6 +16,7 @@ module.exports = {
   ],
   rules: {
     'nuxt/no-env-in-context': 'error',
+    'nuxt/no-env-in-mounted': 'error',
     'nuxt/no-this-in-fetch-data': 'error'
   }
 }

lib/index.js

@@ -1,6 +1,7 @@
 module.exports = {
   rules: {
     'no-env-in-context': require('./rules/no-env-in-context'),
+    'no-env-in-mounted': require('./rules/no-env-in-mounted'),
     'no-globals-in-created': require('./rules/no-globals-in-created'),
     'no-this-in-fetch-data': require('./rules/no-this-in-fetch-data'),
     'no-timing-in-fetch-data': require('./rules/no-timing-in-fetch-data')

lib/rules/__test__/no-env-in-mounted.test.js

@@ -0,0 +1,96 @@
+/**
+ * @fileoverview disallow `process.server/process.client` in `mounted/beforeMount`
+ * @author Xin Du <[email protected]>
+ */
+'use strict'
+
+// ------------------------------------------------------------------------------
+// Requirements
+// ------------------------------------------------------------------------------
+
+var rule = require('../no-env-in-mounted')
+
+var RuleTester = require('eslint').RuleTester
+
+const parserOptions = {
+  ecmaVersion: 2018,
+  sourceType: 'module'
+}
+
+// ------------------------------------------------------------------------------
+// Tests
+// ------------------------------------------------------------------------------
+
+var ruleTester = new RuleTester()
+ruleTester.run('no-env-in-mounted', rule, {
+
+  valid: [
+    {
+      filename: 'test.vue',
+      code: `
+        export default {
+          mounted() {
+            const foo = 'bar'
+          },
+          beforeMount() {
+            const foo = 'bar'
+          }
+        }
+      `,
+      parserOptions
+    }
+  ],
+
+  invalid: [
+    {
+      filename: 'test.vue',
+      code: `
+        export default {
+          mounted() {
+            if(process.server) {
+              const foo = 'bar'
+            }
+          },
+          beforeMount() {
+            if(process.client) {
+              const foo = 'bar'
+            }
+          }
+        }
+      `,
+      errors: [{
+        message: 'Unexpected process.server in mounted.',
+        type: 'MemberExpression'
+      }, {
+        message: 'Unexpected process.client in beforeMount.',
+        type: 'MemberExpression'
+      }],
+      parserOptions
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        export default {
+          mounted() {
+            if(process['client']) {
+              const foo = 'bar'
+            }
+          },
+          beforeMount() {
+            if(process['server']) {
+              const foo = 'bar'
+            }
+          }
+        }
+      `,
+      errors: [{
+        message: 'Unexpected process.client in mounted.',
+        type: 'MemberExpression'
+      }, {
+        message: 'Unexpected process.server in beforeMount.',
+        type: 'MemberExpression'
+      }],
+      parserOptions
+    }
+  ]
+})

lib/rules/no-env-in-mounted.js

@@ -0,0 +1,66 @@
+/**
+ * @fileoverview disallow `process.server/process.client` in `mounted/beforeMount`
+ * @author Xin Du <[email protected]>
+ */
+'use strict'
+
+const utils = require('../utils')
+
+// ------------------------------------------------------------------------------
+// Rule Definition
+// ------------------------------------------------------------------------------
+
+module.exports = {
+  meta: {
+    docs: {
+      description:
+        'disallow `process.server/process.client` in `mounted/beforeMount`',
+      category: 'base'
+    },
+    messages: {
+      noEnv: 'Unexpected {{name}} in {{funcName}}.'
+    }
+  },
+
+  create: function (context) {
+    // variables should be defined here
+    const forbiddenNodes = []
+    const options = context.options[0] || {}
+
+    const ENV = ['server', 'client']
+    const HOOKS = new Set(['mounted', 'beforeMount'].concat(options.methods || []))
+
+    // ----------------------------------------------------------------------
+    // Public
+    // ----------------------------------------------------------------------
+
+    return {
+      MemberExpression (node) {
+        const objectName = node.object.name
+        if (objectName === 'process') {
+          const propertyName = node.computed ? node.property.value : node.property.name
+          if (propertyName && ENV.includes(propertyName)) {
+            forbiddenNodes.push({ name: 'process.' + propertyName, node })
+          }
+        }
+      },
+      ...utils.executeOnVue(context, obj => {
+        for (const funcName of HOOKS) {
+          const func = utils.getFunctionWithName(obj, funcName)
+          for (const { name, node: child } of forbiddenNodes) {
+            if (utils.isInFunction(func, child)) {
+              context.report({
+                node: child,
+                messageId: 'noEnv',
+                data: {
+                  name,
+                  funcName
+                }
+              })
+            }
+          }
+        }
+      })
+    }
+  }
+}