fix: dont change title when value is undefined (fix #396)

pimlie · pimlie · commit 90f9710f2693 · 2019-06-22T16:15:49.000+02:00
diff --git a/examples/basic/index.html b/examples/basic/index.html
@@ -1,5 +1,12 @@
 <!DOCTYPE html>
-<link rel="stylesheet" href="/global.css">
-<a href="/">&larr; Examples index</a>
-<div id="app"></div>
-<script src="/__build__/basic.js"></script>
+<html>
+<head>
+  <title>Basic Title</title>
+  <link rel="stylesheet" href="/global.css">
+</head>
+<body>
+  <a href="/">&larr; Examples index</a>
+  <div id="app"></div>
+  <script src="/__build__/basic.js"></script>
+</body>
+</html>
diff --git a/src/client/updaters/title.js b/src/client/updaters/title.js
@@ -3,6 +3,10 @@
  *
  * @param  {String} title - the new title of the document
  */
-export default function updateTitle(title = document.title) {
+export default function updateTitle(title) {
+  if (title === undefined) {
+    return
+  }
+
   document.title = title
 }
diff --git a/src/shared/constants.js b/src/shared/constants.js
@@ -4,7 +4,7 @@
 
 // set some sane defaults
 export const defaultInfo = {
-  title: '',
+  title: undefined,
   titleChunk: '',
   titleTemplate: '%s',
   htmlAttrs: {},
diff --git a/test/unit/components.test.js b/test/unit/components.test.js
@@ -90,7 +90,7 @@ describe('client', () => {
 
     jest.runAllTimers()
     metaInfo = getMetaInfo(wrapper.vm.$parent)
-    expect(metaInfo.title).toEqual('')
+    expect(metaInfo.title).toEqual(undefined)
   })
 
   test('meta-info can be rendered with inject', () => {
diff --git a/test/unit/getMetaInfo.test.js b/test/unit/getMetaInfo.test.js
@@ -13,7 +13,7 @@ describe('getMetaInfo', () => {
     const component = new Vue()
 
     expect(getMetaInfo(component)).toEqual({
-      title: '',
+      title: undefined,
       titleChunk: '',
       titleTemplate: '%s',
       htmlAttrs: {},
@@ -654,7 +654,7 @@ describe('getMetaInfo', () => {
     })
 
     expect(getMetaInfo(component)).toEqual({
-      title: '',
+      title: undefined,
       titleChunk: '',
       titleTemplate: '%s',
       htmlAttrs: {},
@@ -802,7 +802,7 @@ describe('getMetaInfo', () => {
     })
 
     expect(getMetaInfo(component)).toEqual({
-      title: '',
+      title: undefined,
       titleChunk: '',
       titleTemplate: '%s',
       htmlAttrs: {},

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,10 @@`
`3`	`3`	`*`
`4`	`4`	`* @param {String} title - the new title of the document`
`5`	`5`	`*/`
`6`		`-export default function updateTitle(title = document.title) {`
	`6`	`+export default function updateTitle(title) {`
	`7`	`+ if (title === undefined) {`
	`8`	`+ return`
	`9`	`+ }`
	`10`	`+`
`7`	`11`	`document.title = title`
`8`	`12`	`}`