Skip to content

FEATURE: support winborder setting (Neovim 0.11+) #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
xfzv opened this issue Mar 22, 2025 · 1 comment · May be fixed by #1744
Open
1 task done

FEATURE: support winborder setting (Neovim 0.11+) #1743

xfzv opened this issue Mar 22, 2025 · 1 comment · May be fixed by #1744
Labels
enhancement New feature or request waiting-on-upstream An issue caused by Neovim or a dependency

Comments

@xfzv
Copy link

xfzv commented Mar 22, 2025

Did you check the docs?

  • I have read all the docs.

Is your feature request related to a problem? Please describe.

neovim/neovim#31074 introduced new winborder option to define the default border style for floating windows.

Describe the solution you'd like.

If winborder is set, use it instead of popup_border_style.

Describe alternatives you've considered.

No response

Additional Context

No response
@xfzv xfzv added the enhancement New feature or request label Mar 22, 2025
@pynappo
Copy link
Collaborator

pynappo commented Mar 22, 2025 •
edited
Loading

i don't necessarily think it should override popup_border_style because winborder is supposed to be a default, not a global override. otherwise there would be no easy way to configure a separate winborder from other plugins.

i'll make setting popup_border_style to "" use winborder.

@pynappo pynappo linked a pull request Mar 22, 2025 that will close this issue
Open
@pynappo pynappo added the waiting-on-upstream An issue caused by Neovim or a dependency label Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request waiting-on-upstream An issue caused by Neovim or a dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(popup): support 'winborder' with popup_border_style = "" pynappo/neo-tree.nvim
2 participants
@pynappo @xfzv