new watcher event on .git freezes neovim

[DYnamoX513]

Hi,
My neovim freezes for 20 sec after opening nvim-tree in a git repository in WSL.
I cannot reproduce this issue on other devices (MacOS, Linux Mint) . I've tried reinstalling the WSL and all the #549 performance tips, but none of them worked.

I will appreciate any suggestions.
Thanks

nvim-tree.log

[2022-11-04 19:32:52] [watcher] purge_watchers
[2022-11-04 19:32:55] [watcher] Watcher:new '/home/jed/repos/neovim'
[2022-11-04 19:32:55] [watcher] Event:new '/home/jed/repos/neovim'
[2022-11-04 19:32:55] [watcher] Event:start '/home/jed/repos/neovim'
[2022-11-04 19:32:55] [profile] START git toplevel /home/jed/repos/neovim
[2022-11-04 19:32:55] [git] { "git", "-C", "/home/jed/repos/neovim", "rev-parse", "--show-toplevel" }
/home/jed/repos/neovim
[2022-11-04 19:32:55] [profile] END   git toplevel /home/jed/repos/neovim  1ms
[2022-11-04 19:32:55] [profile] START git untracked /home/jed/repos/neovim
[2023-11-04 19:32:55] [git] { "git", "-C", "/home/jed/repos/neovim", "config", "status.showUntrackedFiles" }
[2022-11-04 19:32:55] [profile] END   git untracked /home/jed/repos/neovim  0ms
[2022-11-04 19:32:55] [profile] START git job /home/jed/repos/neovim nil
[2022-11-04 19:32:55] [git] running job with timeout 400ms
[2022-11-04 19:32:55] [git] git --no-optional-locks status --porcelain=v1 --ignored=matching -u
!! .deps/
!! build/
[2022-11-04 19:32:55] [git] done
[2022-11-04 19:32:55] [profile] END   git job /home/jed/repos/neovim nil  3ms
[2022-11-04 19:32:55] [git] job success    /home/jed/repos/neovim nil
[2022-11-04 19:32:55] [watcher] git start

Problem here

[2022-11-04 19:32:55] [watcher] Watcher:new '/home/jed/repos/neovim/.git'
[2022-11-04 19:32:55] [watcher] Event:new '/home/jed/repos/neovim/.git'
[2022-11-04 19:32:55] [watcher] Event:start '/home/jed/repos/neovim/.git'

[2022-11-04 19:33:15] [watcher] Watcher:new '/home/jed/repos/neovim/.github'
[2022-11-04 19:33:15] [watcher] Event:new '/home/jed/repos/neovim/.github'
[2022-11-04 19:33:15] [watcher] Event:start '/home/jed/repos/neovim/.github'
...
[2022-11-04 19:33:15] [watcher] Watcher:new '/home/jed/repos/neovim/test'
[2022-11-04 19:33:15] [watcher] Event:new '/home/jed/repos/neovim/test'
[2022-11-04 19:33:15] [watcher] Event:start '/home/jed/repos/neovim/test'
[2022-11-04 19:33:15] [profile] START draw
[2022-11-04 19:33:15] [profile] END   draw  0ms

config

require("nvim-tree").setup {
		view = {
			mappings = {
				list = {
					{ key = "t", action = "tabnew" },
					{ key = "<C-t>", action = "" },
				},
			},
		},
		log = {
			enable = true,
			truncate = true,
			types = {
				diagnostics = true,
				git = true,
				profile = true,
				watcher = true,
			},
		},
}

Neovim version

NVIM v0.8.0-v0.8.0
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

Operating system and version

> wsl --version
WSL version: 0.70.4.0
Kernel version: 5.15.68.1
WSLg version: 1.0.45
MSRDC version: 1.2.3575
Direct3D version: 1.606.4
DXCore version: 10.0.25131.1002-220531-1700.rs-onecore-base2-hyp
Windows version: 10.0.22621.755

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 22.04.1 LTS
Release:        22.04
Codename:       jammy

[alex-courtis]

Your timing is excellent. I have been looking into git performance: #1721 #1720

The logs at startup seems to indicate things are working normally. What is in the logs in the 20 sec freeze between 2022-11-04 19:32:55 and 2022-11-04 19:33:15 ?

It could be a problem with the .git watcher as per #1720 . I'll be making a fix for that regardless.

In the meantime can you please try the git daemon solution as per #1721

[DYnamoX513]

1. Nothing happened between 2022-11-04 19:32:55 and 2022-11-04 19:33:15. I was just trying to highlight the particular event causing the freeze. It also seems to always freeze for exactly? 20 seconds, no matter how large/small a git repo is.
2. I'm trying Recommend core.fsmonitor For macOS And Windows Users #1721. However, it's not supported by git-2.38 in Ubuntu. fatal: fsmonitor--daemon not supported on this platform

[alex-courtis]

• Nothing happened between 2022-11-04 19:32:55 and 2022-11-04 19:33:15. I was just trying to highlight the particular event causing the freeze. It also seems to always freeze for exactly? 20 seconds, no matter how large/small a git repo is.

Very interesting. It will be interesting to try #1720 as the issue occurs after creating the .git watcher. I will reply when this branch is available.

As a control: please temporarily disable git integration by setting git.enable to false. We should be certain that this is a git integration issue.

• I'm trying Recommend core.fsmonitor For macOS And Windows Users #1721. However, it's not supported by git-2.38 in Ubuntu. fatal: fsmonitor--daemon not supported on this platform

I see. WSL is considered linux. Thanks for testing that out.

[alex-courtis]

@DYnamoX513 I will be grateful if you can test the fix #1725

cd /path/to/nvim-tree.lua
git pull
git checkout 1720-remove-dot-git-watcher

[DYnamoX513]

Thanks for the reply @alex-courtis
#1725 The 20s gap now presents after the [git] job success. (tried in different repos and the results remain the same)

cat .cache/nvim/nvim-tree.log
[2022-11-05 02:13:38] [watcher] purge_watchers
[2022-11-05 02:13:40] [watcher] Watcher:new '/home/jed/repos/neovim'
[2022-11-05 02:13:40] [watcher] Event:new '/home/jed/repos/neovim'
[2022-11-05 02:13:40] [watcher] Event:start '/home/jed/repos/neovim'
[2022-11-05 02:13:40] [profile] START git toplevel /home/jed/repos/neovim
[2022-11-05 02:13:40] [git] { "git", "-C", "/home/jed/repos/neovim", "rev-parse", "--show-toplevel" }
/home/jed/repos/neovim
[2022-11-05 02:13:40] [profile] END   git toplevel /home/jed/repos/neovim  1ms
[2022-11-05 02:13:40] [profile] START git untracked /home/jed/repos/neovim
[2022-11-05 02:13:40] [git] { "git", "-C", "/home/jed/repos/neovim", "config", "status.showUntrackedFiles" }
[2022-11-05 02:13:40] [profile] END   git untracked /home/jed/repos/neovim  0ms
[2022-11-05 02:13:40] [profile] START git job /home/jed/repos/neovim nil
[2022-11-05 02:13:40] [git] running job with timeout 400ms
[2022-11-05 02:13:40] [git] git --no-optional-locks status --porcelain=v1 --ignored=matching -u
!! .deps/
!! build/
[2022-11-05 02:13:40] [git] done
[2022-11-05 02:13:40] [profile] END   git job /home/jed/repos/neovim nil  97ms
[2022-11-05 02:13:40] [git] job success    /home/jed/repos/neovim nil
----------------here----------------
[2022-11-05 02:14:00] [watcher] Watcher:new '/home/jed/repos/neovim/.github'
[2022-11-05 02:14:00] [watcher] Event:new '/home/jed/repos/neovim/.github'
[2022-11-05 02:14:00] [watcher] Event:start '/home/jed/repos/neovim/.github'
...
[2022-11-05 02:14:00] [watcher] Watcher:new '/home/jed/repos/neovim/test'
[2022-11-05 02:14:00] [watcher] Event:new '/home/jed/repos/neovim/test'
[2022-11-05 02:14:00] [watcher] Event:start '/home/jed/repos/neovim/test'
[2022-11-05 02:14:00] [profile] START draw
[2022-11-05 02:14:00] [profile] END   draw  0ms

And if I set git.enable=false

[2022-11-05 02:21:06] [watcher] purge_watchers
[2022-11-05 02:21:07] [watcher] Watcher:new '/home/jed/repos/neovim'
[2022-11-05 02:21:07] [watcher] Event:new '/home/jed/repos/neovim'
[2022-11-05 02:21:07] [watcher] Event:start '/home/jed/repos/neovim'
----------------here----------------
[2022-11-05 02:21:27] [watcher] Watcher:new '/home/jed/repos/neovim/.deps'
[2022-11-05 02:21:27] [watcher] Event:new '/home/jed/repos/neovim/.deps'
[2022-11-05 02:21:27] [watcher] Event:start '/home/jed/repos/neovim/.deps'
...
[2022-11-05 02:21:27] [watcher] Watcher:new '/home/jed/repos/neovim/test'
[2022-11-05 02:21:27] [watcher] Event:new '/home/jed/repos/neovim/test'
[2022-11-05 02:21:27] [watcher] Event:start '/home/jed/repos/neovim/test'
[2022-11-05 02:21:27] [profile] START draw
[2022-11-05 02:21:27] [profile] END   draw  0ms

[alex-courtis]

And if I set git.enable=false

This is very interesting.

Let's keep narrowing it down: please try without any file system watchers:

    filesystem_watchers = {
      enable = false,
    }

Please also log everything to see if there is something else we are missing:

    log = {
      enable = true,
      truncate = true,
      types = {
        all = true,
      }
    }

Is it possible to share the repo so that I may attempt replication with it?

[alex-courtis]

Continuing in #1831