refactored loop through templates

Author: edwmurph

Diff for: test/fast/Unit tests/nvm_get_node_from_pkg_json

@@ -7,10 +7,9 @@ die () { printf "$@" ; exit 1; }
 # posix compliant array needed to support iterating an asterisk without it being evaluated to the list of files in the current dir
 set -- '1.1.1' '1.1' '1' '~1.1.1' '<1.1.1' '<=1.1.1' '>1.1.1' '>=1.1.1' '1.1.1-1.1.2' '^1.1.1' '*' '=1.1.1' 'v1.1.1' 'x' 'X' '1.x.x' '1.X.X'
 
-PKG_JSON_TEMPLATES=$(ls package_json_templates)
-for TEMPLATE_NAME in $PKG_JSON_TEMPLATES; do
+for TEMPLATE_NAME in package_json_templates/*; do
   for TEST_SEMVER in "$@"; do
-    INPUT=$(sed 's/NODE_SEMVER/'"$TEST_SEMVER"'/g' "package_json_templates/$TEMPLATE_NAME")
+    INPUT=$(sed 's/NODE_SEMVER/'"$TEST_SEMVER"'/g' "$TEMPLATE_NAME")
     ACTUAL_OUTPUT=$(nvm_get_node_from_pkg_json "$INPUT")
     [ "$ACTUAL_OUTPUT" = "$TEST_SEMVER" ] && [ -n "$ACTUAL_OUTPUT" ] && [ -n "$INPUT" ] || die "'nvm_get_node_from_pkg_json' failed. Expected '$TEST_SEMVER' but got '$ACTUAL_OUTPUT' when given input template '$TEMPLATE_NAME':\n$INPUT"
   done