Skip to content

Commit 0b8caa0

Browse files
committed
refactor: use map.contains_key() instead of iterating
using map.contains_key is easier to understand and probably has better lookup time Signed-off-by: Luke-zhang-04 <[email protected]>
1 parent 6fdb61d commit 0b8caa0

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

src/onefetch/deps/mod.rs

+1-7
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,6 @@ impl DependencyDetector {
4040
DependencyDetector { package_managers }
4141
}
4242

43-
fn is_package_file(&self, file_name: &str) -> bool {
44-
self.package_managers.iter().any(|(package_manager_file_name, _)| {
45-
file_name.starts_with(package_manager_file_name)
46-
})
47-
}
48-
4943
pub fn get_deps_info(&self, dir: &str) -> Result<String> {
5044
let deps = fs::read_dir(dir)
5145
.chain_err(|| "Could not read directory")?
@@ -56,7 +50,7 @@ impl DependencyDetector {
5650
&& entry
5751
.file_name()
5852
.map(OsStr::to_string_lossy)
59-
.map(|s| self.is_package_file(s.as_ref()))
53+
.map(|s| self.package_managers.contains_key(s.as_ref()))
6054
.unwrap_or_default()
6155
})
6256
.map(|entry| {

0 commit comments

Comments
 (0)