Skip to content

Commit 9849aad

Browse files
committed
remove language::unknown
1 parent 597e17d commit 9849aad

File tree

5 files changed

+11
-34
lines changed

5 files changed

+11
-34
lines changed

Diff for: resources/unknown.ascii

-16
This file was deleted.

Diff for: src/onefetch/cli.rs

+3-4
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ use {
1515
pub struct Cli {
1616
pub path: String,
1717
pub ascii_input: Option<String>,
18-
pub ascii_language: Language,
18+
pub ascii_language: Option<Language>,
1919
pub ascii_colors: Vec<String>,
2020
pub disabled_fields: info_fields::InfoFieldOn,
2121
pub no_bold: bool,
@@ -63,7 +63,6 @@ impl Cli {
6363
.help("Which LANGUAGE's ascii art to print.")
6464
.possible_values(
6565
&Language::iter()
66-
.filter(|language| *language != Language::Unknown)
6766
.map(|language| language.into())
6867
.collect::<Vec<&str>>()
6968
),
@@ -269,9 +268,9 @@ impl Cli {
269268
let ascii_input = matches.value_of("ascii-input").map(String::from);
270269

271270
let ascii_language = if let Some(ascii_language) = matches.value_of("ascii-language") {
272-
Language::from_str(&ascii_language.to_lowercase()).unwrap()
271+
Some(Language::from_str(&ascii_language.to_lowercase()).unwrap())
273272
} else {
274-
Language::Unknown
273+
None
275274
};
276275

277276
let ascii_colors = if let Some(values) = matches.values_of("ascii-colors") {

Diff for: src/onefetch/cli_utils.rs

+4-6
Original file line numberDiff line numberDiff line change
@@ -75,20 +75,18 @@ impl<W: Write> Printer<W> {
7575
}
7676

7777
fn get_ascii(&self) -> &str {
78-
let language = if let Language::Unknown = self.info.config.ascii_language {
79-
&self.info.dominant_language
78+
let language = if let Some(ascii_language) = &self.info.config.ascii_language {
79+
ascii_language
8080
} else {
81-
&self.info.config.ascii_language
81+
&self.info.dominant_language
8282
};
8383

8484
language.get_ascii_art()
8585
}
8686
}
8787

8888
pub fn print_supported_languages() -> Result<()> {
89-
let iterator = Language::iter().filter(|x| *x != Language::Unknown);
90-
91-
for l in iterator {
89+
for l in Language::iter() {
9290
println!("{}", l);
9391
}
9492

Diff for: src/onefetch/info.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -556,15 +556,15 @@ impl Info {
556556
}
557557

558558
fn get_ascii_colors(
559-
ascii_language: &Language,
559+
ascii_language: &Option<Language>,
560560
dominant_language: &Language,
561561
ascii_colors: &[String],
562562
true_color: bool,
563563
) -> Vec<Color> {
564-
let language = if let Language::Unknown = ascii_language {
565-
&dominant_language
564+
let language = if let Some(ascii_language) = ascii_language {
565+
ascii_language
566566
} else {
567-
&ascii_language
567+
&dominant_language
568568
};
569569

570570
let colors = language.get_colors(true_color);

Diff for: src/onefetch/language.rs

-4
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,12 @@ macro_rules! define_languages {
2828
$( #[strum(serialize = $serialize)] )?
2929
$name ,
3030
)*
31-
Unknown,
3231
}
3332

3433
impl std::fmt::Display for Language {
3534
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
3635
match *self {
3736
$( Language::$name => write!(f, $display), )*
38-
Language::Unknown => write!(f, "Unknown" ),
3937
}
4038
}
4139
}
@@ -53,14 +51,12 @@ macro_rules! define_languages {
5351
pub fn get_ascii_art(&self) -> &str {
5452
match *self {
5553
$( Language::$name => include_str!(concat!(env!("CARGO_MANIFEST_DIR"), "/resources/", $ascii)), )*
56-
Language::Unknown => include_str!(concat!(env!("CARGO_MANIFEST_DIR"), "/resources/unknown.ascii")),
5754
}
5855
}
5956

6057
pub fn get_colors(&self, true_color: bool) -> Vec<Color> {
6158
let colors = match *self {
6259
$( Language::$name => $colors, )*
63-
Language::Unknown => define_colors!( [Color::White] ),
6460
};
6561
match colors.true_colors {
6662
Some( true_colors ) if true_color => true_colors,

0 commit comments

Comments
 (0)