Skip to content

Commit a5c3c93

Browse files
committed
fix cargo clippy warnings
1 parent e3c87c3 commit a5c3c93

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

Diff for: src/image_backends/kitty.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,9 @@ impl super::ImageBackend for KittyBackend {
119119
.as_bytes(),
120120
);
121121
image_data.extend(chunk);
122-
image_data.extend("\x1B\\".as_bytes());
122+
image_data.extend(b"\x1B\\");
123123
}
124-
image_data.extend("\x1B_Gm=0;\x1B\\".as_bytes()); // write empty last chunk
124+
image_data.extend(b"\x1B_Gm=0;\x1B\\"); // write empty last chunk
125125
image_data.extend(format!("\x1B[{}A", image_rows as u32 - 1).as_bytes()); // move cursor to start of image
126126
let mut i = 0;
127127
for line in &lines {

Diff for: src/image_backends/sixel.rs

+7-7
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ impl SixelBackend {
5858
buf.push(byte);
5959
if buf.starts_with(&[0x1B, b'[', b'?']) && buf.ends_with(&[b'c']) {
6060
for attribute in buf[3..(buf.len() - 1)].split(|x| *x == b';') {
61-
if attribute == &[b'4'] {
61+
if attribute == [b'4'] {
6262
unsafe {
6363
tcsetattr(STDIN_FILENO, TCSANOW, &old_attributes);
6464
}
@@ -107,7 +107,7 @@ impl super::ImageBackend for SixelBackend {
107107
});
108108

109109
let mut image_data = Vec::<u8>::new();
110-
image_data.extend("\x1BPq".as_bytes()); // start sixel data
110+
image_data.extend(b"\x1BPq"); // start sixel data
111111
image_data.extend(format!("\"1;1;{};{}", image.width(), image.height()).as_bytes());
112112

113113
let mut colors = std::collections::HashMap::<Rgb<u8>, u8>::new();
@@ -137,20 +137,20 @@ impl super::ImageBackend for SixelBackend {
137137
}
138138
}
139139
for (color, color_index) in &colors {
140-
let mut sixel_samples = Vec::<u8>::with_capacity(sixel_row.width() as usize);
140+
let mut sixel_samples = vec![0; sixel_row.width() as usize];
141141
sixel_samples.resize(sixel_row.width() as usize, 0);
142142
for (x, y, pixel) in sixel_row.pixels() {
143143
if color == &pixel {
144-
sixel_samples[x as usize] = sixel_samples[x as usize] | (1 << y);
144+
sixel_samples[x as usize] |= 1 << y;
145145
}
146146
}
147147
image_data.extend(format!("#{}", color_index).bytes());
148148
image_data.extend(sixel_samples.iter().map(|x| x + 0x3F));
149-
image_data.push('$' as u8);
149+
image_data.push(b'$');
150150
}
151-
image_data.push('-' as u8);
151+
image_data.push(b'-');
152152
}
153-
image_data.extend("\x1B\\".as_bytes());
153+
image_data.extend(b"\x1B\\");
154154

155155
image_data.extend(format!("\x1B[{}A", image_rows as u32 + 2).as_bytes()); // move cursor to top-left corner
156156
image_data.extend(format!("\x1B[{}C", image_columns as u32 + 1).as_bytes()); // move cursor to top-right corner of image

Diff for: src/info.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ impl Info {
331331
Info::get_last_change(workdir_str),
332332
Info::get_creation_time(workdir_str),
333333
Info::get_project_license(workdir_str),
334-
Language::get_dominant_language(languages_stats.clone())
334+
Language::get_dominant_language(&languages_stats)
335335
);
336336

337337
let conf = config?;
@@ -382,10 +382,10 @@ impl Info {
382382
}
383383

384384
if let Some(url) = remote_upstream {
385-
remote_url = url.clone();
385+
remote_url = url;
386386
}
387387

388-
let url = remote_url.clone();
388+
let url = remote_url;
389389
let name_parts: Vec<&str> = url.split('/').collect();
390390

391391
if !name_parts.is_empty() {
@@ -399,7 +399,7 @@ impl Info {
399399
}
400400

401401
Ok(Configuration {
402-
repository_name: repository_name.clone(),
402+
repository_name,
403403
repository_url: name_parts.join("/"),
404404
})
405405
}

Diff for: src/language.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ impl Language {
368368
Ok((stat_vec, loc))
369369
}
370370

371-
pub async fn get_dominant_language(languages_stat_vec: Vec<(Language, f64)>) -> Language {
371+
pub async fn get_dominant_language(languages_stat_vec: &[(Language, f64)]) -> Language {
372372
languages_stat_vec[0].0.clone()
373373
}
374374
}
@@ -396,7 +396,7 @@ fn project_languages(dir: &str, ignored_directories: Vec<&str>) -> tokei::Langua
396396
let mut v = Vec::with_capacity(ignored_directories.len());
397397
for ignored in ignored_directories {
398398
if re.is_match(ignored) {
399-
let p = if ignored.starts_with("/") {
399+
let p = if ignored.starts_with('/') {
400400
"**"
401401
} else {
402402
"**/"

0 commit comments

Comments
 (0)