Skip to content

Run cargo update #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Run cargo update #404

merged 2 commits into from
Mar 12, 2021

Conversation

spenserblack
Copy link
Collaborator

@spenserblack spenserblack commented Mar 12, 2021

Fixes severe warnings for generic-array and rand_core.

@spenserblack spenserblack requested a review from o2sh March 12, 2021 14:29
@o2sh
Copy link
Owner

o2sh commented Mar 12, 2021

Thanks for fixing the build @spenserblack, I see that you've updated more than just generic-array and rand_core in the Cargo.lock. Is there a reason for that ? Especially image and libc which would de-sync with the version specified in the Cargo.toml. We should maybe merge #401 and #399 before regenerating the Cargo.lock ?

@spenserblack
Copy link
Collaborator Author

spenserblack commented Mar 12, 2021

@o2sh Good catch! That was the result of running cargo update without any additional arguments, which updates all dependencies by default. Now that you've brought it up, I think it's probably best to only update those few dependencies. I'll push up a new branch head.

Verified

This commit was signed with the committer’s verified signature.
spenserblack Spenser Black
Fixes audit issue RUSTSEC-2020-0146

Verified

This commit was signed with the committer’s verified signature.
spenserblack Spenser Black
Fixes audit issue RUSTSEC-2021-0023
@spenserblack
Copy link
Collaborator Author

The remaining audit warnings seem to be upstream issues with tokei's and askalono's unmaintained dependencies, and it doesn't look like there is a new release yet of either that would fix those audit warnings.

@o2sh o2sh merged commit af24c66 into o2sh:master Mar 12, 2021
@spenserblack spenserblack deleted the audit-fix branch March 12, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants