Skip to content

Add CLI option for displaying author emails #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 30, 2021
Merged

Add CLI option for displaying author emails #452

merged 7 commits into from
Jun 30, 2021

Conversation

remkop22
Copy link
Contributor

@remkop22 remkop22 commented Jun 30, 2021 •
edited
Loading

feature request, closes #451

Add email flag to cli args
f7d7c4b 
In order to display emails of authors, users can enable `email` cli flag
spenserblack
spenserblack requested changes Jun 30, 2021
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

I left some suggestions about code style, which I believe would be necessary to pass the format check in the CI.

@spenserblack
Copy link
Collaborator

spenserblack commented Jun 30, 2021 •
edited
Loading

Also, looks like your commits aren't getting mapped to your GitHub account. Probably an email mismatch. Do you need to amend the commit author? Not a big deal, but I wouldn't want for you to not get credit for your work 🙂

Display email when cli flag is set
f0639f0 
Changed type of author to contain `Option<String>`. This field is
initialized when the email cli flag is set. If the email is Some() it
is formatted together with the username and displayed.
remkop22 and others added 2 commits June 30, 2021 15:37
@remkop22 @spenserblack
Update src/onefetch/info.rs
db72f4c 
Co-authored-by: Spenser Black <[email protected]>
@remkop22 @spenserblack
Update src/onefetch/repo.rs
b749d7e 
Co-authored-by: Spenser Black <[email protected]>
@remkop22
Copy link
Contributor Author

Thanks for your PR!

I left some suggestions about code style, which I believe would be necessary to pass the format check in the CI.

Thanks a bunch for the suggestions! Will be more careful regarding formatting and tab-size in the future.

Also, looks like your commits aren't getting mapped to your GitHub account. Probably an email mismatch. Do you need to amend the commit author? Not a big deal, but I wouldn't want for you to not get credit for your work 🙂

Oops! I fixed my git settings, but no need to amend them for this PR.

@remkop22 remkop22 requested a review from spenserblack June 30, 2021 13:47
spenserblack
spenserblack requested changes Jun 30, 2021
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Looks like there's one more change to pass the formatting check.

@remkop22 remkop22 requested a review from spenserblack June 30, 2021 14:13
spenserblack
spenserblack approved these changes Jun 30, 2021
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@o2sh o2sh merged commit 0130a25 into o2sh:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spenserblack spenserblack spenserblack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CLI flag to display "username <email>" in the Author section ✉️
3 participants
@remkop22 @spenserblack @o2sh