Merge branch '35-remove-valgrind'

Author: greenrobot-team

.github/workflows/dart.yml

@@ -72,28 +72,6 @@ jobs:
           ../tool/pub.sh run build_runner build
           ../tool/pub.sh run test
 
-# Temporarily disabled, see internal issue.
-#  valgrind:
-#    runs-on: ubuntu-22.04
-#    steps:
-#      - uses: actions/checkout@v3
-#      - uses: dart-lang/setup-dart@v1
-#        with:
-#          sdk: 2.19.2
-#      - name: Install ObjectBox C-API
-#        run: ./install.sh
-#      - name: Install Valgrind
-#        run: ./tool/apt-install.sh valgrind
-#      - name: Test
-#        working-directory: objectbox_test
-#        # Run shorter tests, if available (to prevent timeouts in CI).
-#        env:
-#          TEST_SHORT: 1
-#        run: |
-#          dart pub get
-#          dart run build_runner build
-#          ./tool/valgrind.sh
-
   flutter-integration-test:
     strategy:
       fail-fast: false

objectbox_test/Makefile

@@ -1,7 +1,7 @@
 # Default target executed when no arguments are given to make.
 default: help
 
-.PHONY: default help depend test valgrind-test
+.PHONY: default help depend test
 
 help:			## Show this help
 	@grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'
@@ -15,7 +15,3 @@ depend:			## Build dependencies
 test: 			## Generate code and run unit tests
 	dart run build_runner build
 	dart run test
-
-valgrind-test: 		## Test all targets with valgrind
-	dart run build_runner build
-	./tool/valgrind.sh

objectbox_test/test/query_property_test.dart

@@ -62,14 +62,6 @@ void main() {
 
   final tString = TestEntity_.tString;
 
-  test('property query auto-close', () {
-    // Finalizer is executed after the query object goes out of scope.
-    // Note: only caught by valgrind - I've tested that it actually catches
-    // when the finalizer assignment was disabled. Now, this will only fail in
-    // CI when running valgrind.sh - if finalizer won't work properly.
-    box.query().build().property(TestEntity_.tString).find();
-  });
-
   test('.count (basic query)', () {
     box.putMany(integerList());
     box.putMany(stringList());

objectbox_test/test/query_test.dart

@@ -19,14 +19,6 @@ void main() {
   });
   tearDown(() => env.closeAndDelete());
 
-  test('Query auto-close', () {
-    // Finalizer is executed after the query object goes out of scope.
-    // Note: only caught by valgrind - I've tested that it actually catches
-    // when the finalizer assignment was disabled. Now, this will only fail in
-    // CI when running valgrind.sh - if finalizer won't work properly.
-    box.query().build().find();
-  });
-
   test('Query with no conditions, and order as desc ints', () async {
     box.putMany(<TestEntity>[
       TestEntity(tInt: 0),

objectbox_test/test/test_env.dart

@@ -12,8 +12,7 @@ class TestEnv {
   /// If environment variable TEST_SHORT=1 is set, this will be true.
   ///
   /// If true, try to run tests quicker, e.g. with less objects or iterations.
-  /// This is currently only used to speed up valgrind analysis and avoid CI
-  /// timeouts.
+  /// This was used to speed up valgrind analysis and avoid CI timeouts.
   final bool short;
 
   factory TestEnv(String name, {bool? queryCaseSensitive, int? debugFlag}) {