Skip to content

Box provide missing methods #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
vaind opened this issue Oct 15, 2019 · 3 comments
Closed
5 tasks done

Box provide missing methods #36

vaind opened this issue Oct 15, 2019 · 3 comments
Labels
good first issue Good for newcomers help wanted Looking for contributors (ideas, comments, code, etc)

Comments

@vaind
Copy link
Contributor

vaind commented Oct 15, 2019

Box already has get/put as well as their bulk variants. To be more up to par with the rest of the bindings, the following methods should be implemented:

  • count(optional limit)
  • contains(id)
  • isEmpty()
  • remove(id)
  • removeAll()

See box.go and go docs for reference

@vaind vaind added help wanted Looking for contributors (ideas, comments, code, etc) good first issue Good for newcomers labels Oct 15, 2019
@vaind
Copy link
Contributor Author

vaind commented Oct 21, 2019

Thank you @liquidiert 👍 I've merged the PR after resolving some issues caused by the huge query PR changelist.

Could you maybe have a look at the last method (or two): contains(id), containsMany(ids) since you're already familiar with the code and its tests. If so, please start it on a new branch based on the latest dev to prevent merge conflicts, as there have been major changes today.

@liquidiert
Copy link
Contributor

Of course 👍 I'm happy to help 😄

@vaind
Copy link
Contributor Author

vaind commented Oct 22, 2019

thanks for implementing this @liquidiert 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Looking for contributors (ideas, comments, code, etc)
Projects
None yet
Development

No branches or pull requests

2 participants