Skip to content

"median" window reducer stopped working in v0.6.7 #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leoluk opened this issue Jun 14, 2023 · 2 comments · Fixed by #1691
Closed

"median" window reducer stopped working in v0.6.7 #1690

leoluk opened this issue Jun 14, 2023 · 2 comments · Fixed by #1691
Labels
bug Something isn’t working

Comments

@leoluk
Copy link

leoluk commented Jun 14, 2023

As of plot v0.6.7, this code no longer works:

Plot.plot({
  marks: [
    Plot.line(
      data,
      Plot.windowY(
        {
          k: 4,
          anchor: "end",
          reduce: "median"
        },
        {
          x: "date",
          y: "cat"
        }
      )
    )
  ]
})

mean works while median, variance and others don't.

Example notebook: https://observablehq.com/d/1a581f1609384865

Perhaps I'm holding it wrong, but the docs look borked too:

image
@mbostock
Copy link
Member

Thanks for the report! We will investigate.

@mbostock mbostock added the bug Something isn’t working label Jun 14, 2023
@Fil Fil closed this as completed in #1691 Jun 14, 2023
@Fil
Copy link
Contributor

Fil commented Jun 14, 2023

The fix is merged in main, and will be in the next release. The documentation is fixed already :)
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants