Skip to content

Fix failing Python test #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
claremacrae opened this issue Nov 11, 2022 · 2 comments · Fixed by #529
Closed

Fix failing Python test #527

claremacrae opened this issue Nov 11, 2022 · 2 comments · Fixed by #529
Assignees

Comments

@claremacrae
Copy link
Contributor

claremacrae commented Nov 11, 2022

I looked at approving some PRs this evening, and see that one of the tests of python scripts has started failing:
https://github.com/obsidian-community/obsidian-hub/actions/runs/3448377582

image

I've had a quick look at the code and nothing has changed recently, so I assume it's a change in version of a tool that is being used... and pulled in via the GitHub Actions infrastructure.

The code is the second of these 2 lines:

https://github.com/obsidian-community/obsidian-hub/blob/2ab98067db49131355619e5a24e6bda3021682c9/.github/scripts/update_issues.py#L21:L22

class GithubClient:
    def get(self, url: str, _get: str) -> List[Any]: ...
@claremacrae
Copy link
Contributor Author

The failure in a function declared as ... appears to come from changed discussed in:
python/mypy#2350

and implemented in:
python/mypy#13729

@claremacrae
Copy link
Contributor Author

Suggested fix is here:
python/mypy#14048 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant