Skip to content

Commit 1a7d437

Browse files
committed
revert backend change: no more typ_int32&typ_int64
1 parent 561c358 commit 1a7d437

File tree

10 files changed

+4
-36
lines changed

10 files changed

+4
-36
lines changed

backend/cmm.ml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,6 @@ let typ_void = ([||] : machtype_component array)
2626
let typ_val = [|Val|]
2727
let typ_addr = [|Addr|]
2828
let typ_int = [|Int|]
29-
let typ_int32 = [|Int|]
30-
(* XXX ASZ: What layouts version does this go with? *)
31-
(* CR layouts XXX ASZ: Change [typ_int32] to fit in a 32-bit register, rather
32-
than taking up a full 64-bit one. *)
33-
let typ_int64 = if Arch.size_int = 4 then [|Int;Int|] else [|Int|]
3429
let typ_float = [|Float|]
3530
let typ_vec128 = [|Vec128|]
3631

@@ -99,8 +94,8 @@ type exttype =
9994

10095
let machtype_of_exttype = function
10196
| XInt -> typ_int
102-
| XInt32 -> typ_int32
103-
| XInt64 -> typ_int64
97+
| XInt32 -> typ_int
98+
| XInt64 -> typ_int
10499
| XFloat -> typ_float
105100
| XVec128 -> typ_vec128
106101

backend/cmm.mli

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,6 @@ val typ_void: machtype
5454
val typ_val: machtype
5555
val typ_addr: machtype
5656
val typ_int: machtype
57-
val typ_int32: machtype
58-
val typ_int64: machtype
5957
val typ_float: machtype
6058
val typ_vec128: machtype
6159

backend/cmm_helpers.ml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1125,11 +1125,6 @@ module Extended_machtype = struct
11251125

11261126
let typ_any_int = [| Extended_machtype_component.Any_int |]
11271127

1128-
(* XXX ASZ: What layouts version does this go with? *)
1129-
(* CR layouts XXX ASZ: Change this to fit in a 32-bit register, rather than
1130-
taking up a full 64-bit one. *)
1131-
let typ_int32 = [| Extended_machtype_component.Any_int |]
1132-
11331128
let typ_int64 = [| Extended_machtype_component.Any_int |]
11341129

11351130
let typ_float = [| Extended_machtype_component.Float |]

backend/cmm_helpers.mli

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -395,8 +395,6 @@ module Extended_machtype : sig
395395

396396
val typ_any_int : t
397397

398-
val typ_int32 : t
399-
400398
val typ_int64 : t
401399

402400
val typ_float : t

backend/cmmgen.ml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -424,9 +424,7 @@ let machtype_of_sort (s : Jkind.Sort.const) =
424424
match s with
425425
| Value -> typ_val
426426
| Float64 -> typ_float
427-
| Word -> typ_int
428-
| Bits32 -> typ_int32
429-
| Bits64 -> typ_int64
427+
| Word | Bits32 | Bits64 -> typ_int
430428
| Void -> Misc.fatal_error "Cmmgen.machtype_of_sort: void encountered"
431429

432430
let rec is_unboxed_number_cmm = function

ocaml/asmcomp/cmm.ml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,6 @@ let typ_void = ([||] : machtype_component array)
2525
let typ_val = [|Val|]
2626
let typ_addr = [|Addr|]
2727
let typ_int = [|Int|]
28-
let typ_int32 = [|Int|]
29-
(* XXX ASZ: What layouts version does this go with? *)
30-
(* CR layouts XXX ASZ: Change [typ_int32] to fit in a 32-bit register, rather
31-
than taking up a full 64-bit one. *)
32-
let typ_int64 = if Arch.size_int = 4 then [|Int;Int|] else [|Int|]
3328
let typ_float = [|Float|]
3429

3530
(** [machtype_component]s are partially ordered as follows:

ocaml/asmcomp/cmm.mli

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ val typ_void: machtype
5353
val typ_val: machtype
5454
val typ_addr: machtype
5555
val typ_int: machtype
56-
val typ_int32: machtype
57-
val typ_int64: machtype
5856
val typ_float: machtype
5957

6058
(** Least upper bound of two [machtype_component]s. *)

ocaml/asmcomp/cmm_helpers.ml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -912,11 +912,6 @@ module Extended_machtype = struct
912912

913913
let typ_int64 = [| Extended_machtype_component.Any_int |]
914914

915-
(* XXX ASZ: What layouts version does this go with? *)
916-
(* CR layouts XXX ASZ: Change this to fit in a 32-bit register, rather than
917-
taking up a full 64-bit one. *)
918-
let typ_int32 = [| Extended_machtype_component.Any_int |]
919-
920915
let typ_float = [| Extended_machtype_component.Float |]
921916

922917
let typ_void = [||]

ocaml/asmcomp/cmm_helpers.mli

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -311,8 +311,6 @@ module Extended_machtype : sig
311311

312312
val typ_any_int : t
313313

314-
val typ_int32 : t
315-
316314
val typ_int64 : t
317315

318316
val typ_float : t

ocaml/asmcomp/cmmgen.ml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -364,9 +364,7 @@ let machtype_of_sort (s : Jkind.Sort.const) =
364364
match s with
365365
| Value -> typ_val
366366
| Float64 -> typ_float
367-
| Word -> typ_int
368-
| Bits32 -> typ_int32
369-
| Bits64 -> typ_int64
367+
| Word | Bits32 | Bits64 -> typ_int
370368
| Void -> Misc.fatal_error "Cmmgen.machtype_of_sort: void encountered"
371369

372370
let is_unboxed_number_cmm ~strict cmm =

0 commit comments

Comments
 (0)