flambda-backend: Issue misplaced attribute warning earlier (#2155)

Author: gretay-js

driver/compile.ml

@@ -36,6 +36,7 @@ let to_bytecode i Typedtree.{structure; coercion; _} =
     (Translmod.transl_implementation i.module_name ~style:Set_global_to_block)
   |> Profile.(record ~accumulate:true generate)
     (fun { Lambda.code = lambda; required_globals } ->
+       Builtin_attributes.warn_unused ();
        lambda
        |> print_if i.ppf_dump Clflags.dump_rawlambda Printlambda.lambda
        |> Simplif.simplify_lambda

driver/compile_common.ml

@@ -139,6 +139,6 @@ let implementation ~hook_parse_tree ~hook_typed_tree info ~backend =
         backend info typed
       end;
     end;
-    Builtin_attributes.warn_unused ();
+    Builtin_attributes.warn_unchecked_property ();
     Warnings.check_fatal ();
   )

driver/optcompile.ml

@@ -40,6 +40,7 @@ let compile i ~backend ~middle_end ~transl_style
   |> print_if i.ppf_dump Clflags.dump_rawlambda Printlambda.program
   |> Profile.(record generate)
     (fun program ->
+       Builtin_attributes.warn_unused ();
        let code = Simplif.simplify_lambda program.Lambda.code in
        { program with Lambda.code }
        |> print_if i.ppf_dump Clflags.dump_lambda Printlambda.program

parsing/builtin_attributes.ml

@@ -38,6 +38,10 @@ let mark_property_checked txt loc =
 let register_property attr =
     Attribute_table.replace unchecked_properties attr ()
 let warn_unchecked_property () =
+    (* When using -i, attributes will not have been translated, so we can't
+     warn about missing ones. *)
+  if !Clflags.print_types then ()
+  else
   let keys = List.of_seq (Attribute_table.to_seq_keys unchecked_properties) in
   let keys = List.sort attr_order keys in
   List.iter (fun sloc ->
@@ -50,7 +54,6 @@ let warn_unused () =
   if !Clflags.print_types then ()
   else
   begin
-    warn_unchecked_property ();
     let keys = List.of_seq (Attribute_table.to_seq_keys unused_attrs) in
     let keys = List.sort attr_order keys in
     List.iter (fun sloc ->

parsing/builtin_attributes.mli

@@ -92,6 +92,7 @@ val mark_payload_attrs_used : Parsetree.payload -> unit
 (** Issue misplaced attribute warnings for all attributes created with
     [mk_internal] but not yet marked used. *)
 val warn_unused : unit -> unit
+val warn_unchecked_property : unit -> unit
 
 val check_alerts: Location.t -> Parsetree.attributes -> string -> unit
 val check_alerts_inclusion: